Skip to content
This repository has been archived by the owner on Nov 18, 2024. It is now read-only.

Customize TT5's link styles #72

Closed
beafialho opened this issue Aug 19, 2024 · 7 comments
Closed

Customize TT5's link styles #72

beafialho opened this issue Aug 19, 2024 · 7 comments

Comments

@beafialho
Copy link
Contributor

Because the link styles usually look a bit rough, I suggest we add something like the following, unless someone has a better alternative, to improve the appearance of the theme's link underlines.

/*
 * Link styles
 * https://github.com/WordPress/gutenberg/issues/42319
 */
a {
	text-decoration-thickness: 1px !important;
	text-underline-offset: .1em;
}

Here's a before/after:
Captura de ecrã 2024-08-19, às 11 35 51
Captura de ecrã 2024-08-19, às 11 36 04

@beafialho
Copy link
Contributor Author

cc: @carolinan @juanfra @richtabor

@carolinan
Copy link
Contributor

I think we should add this to style.css (!) and not theme.json, for the same reasons mentioned in
#6

@beafialho
Copy link
Contributor Author

Yes, my intent was to add it to style.css

@carolinan
Copy link
Contributor

I wonder if there should also be an animation to ease it in and out?

@beafialho
Copy link
Contributor Author

I wonder if there should also be an animation to ease it in and out?

That would be so cool!

@melchoyce
Copy link
Contributor

It's not currently possible to add an animation between text-decoration: none and text-decoration: underline. The only properties that can animate are text-decoration-color and text-decoration-thickness. I've tried a few iterations of animating text-decoration-color and don't think it'll work based on how the styles are set up. In order to add an animation, we'd need to refactor the underline styles to use pseudo-classes instead of text-decoration for link styles.

@carolinan
Copy link
Contributor

Thank you @melchoyce. I will close this issue as completed. 😞

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants