Add translator note for multilingual strings.

[peterwilsoncc]

Description

• adds a translator note for the strings “Stories, historias, iсторії, iστορίες” to clarify that the strings are intended to contain the word "Stories" in four languages.
• Modifies the context for each of the sample/placeholder headings to be consistent. In one location it differed.

Screenshots

N/A

Testing Instructions

1. Ensure the addition of the line breaks within the headings has not impacted the display negatively.

[github-actions]

Preview changes

You can preview these changes by following the link below:

• Preview changes for twentytwentyfive

I will update this comment with the latest preview links as you push more changes to this PR.

Note

The preview sites are created using WordPress Playground. You can add content, edit settings, and test the themes as you would on a real site, but please note that changes are not saved between sessions.

[github-actions]

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: peterwilsoncc <[email protected]>
Co-authored-by: juanfra <[email protected]>
Co-authored-by: audrasjb <[email protected]>
Co-authored-by: swissspidy <[email protected]>
Co-authored-by: SergeyBiryukov <[email protected]>
Co-authored-by: carolinan <[email protected]>
Co-authored-by: beafialho <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

[juanfra]

Thank you Peter! The addition of the line breaks in comments don't seem to be impacting the display.

Screen.Recording.2024-10-23.at.09.56.55.mov

I have a question regarding the translators comment. What would the expectation be for translators with the following part of the comment: "with the first item in the locale's language."

If I'd be translating to Spanish and I'd read that comment I'd think that the translated string should be" “Historias, stories, iсторії, iστορίες“. In French “Histoires, historias, iсторії, iστορίες“.

Should we give the direction of having the first word in the locale's language or should we leave it open so that the translators take care of it? I am asking this as I am not sure how this would translate to other languages in some locales and if it'd be affecting the display of some patterns.

[peterwilsoncc]

Should we give the direction of having the first word in the locale's language or should we leave it open so that the translators take care of it? I am asking this as I am not sure how this would translate to other languages in some locales and if it'd be affecting the display of some patterns.

I'm not sure worry. My thinking was that having it in the locale's language first would make it clearer to people making use of the theme but I'll check in with a couple of people on translation teams.

[juanfra]

Thank you Peter.

@beafialho as a non-native English speaker and designer of the theme what are your thoughts on this? "Stories" translates to "Histórias" in Portuguese.

@carolinan do you have any thoughts on this?

Thank you all!

[audrasjb]

Left a comment about the accessibility of this string :)

[audrasjb]

I don't have any issue with keeping this text untranslated in French locale, but if we want this theme to be accessibility-ready (which should be our goal), I need to indicate language changes with HTML markup.

[beafialho]

@beafialho as a non-native English speaker and designer of the theme what are your thoughts on this? "Stories" translates to "Histórias" in Portuguese.

@juanfra that's right, "Histórias" is the correct translation for Portuguese.

Should we give the direction of having the first word in the locale's language or should we leave it open so that the translators take care of it?

Having the first word in the locale's language seems ok to me.

[audrasjb]

I'm not opposed to have multilangual strings, but to claim the accessibility-ready tag, Twenty Twenty-Five will have to depend on polyglots using correct html markup.
Another solution is to make this string untranslatable, and to hardcode these <span lang="XX"> tags for each individual string.
Eventually, this would be our best option here.

[peterwilsoncc]

Another solution is to make this string untranslatable, and to hardcode these <span lang="XX"> tags for each individual string.

I'd like to keep it translatable so the locale's language can be included in the string. If the string was Historias, iсторії, iστορίες, истории I'd have no idea what it was conveying so I imagine the same would be true for the roughly 50% of people using a non-english version of WordPress.

I've asked in the #polyglots slack channel (requires login via chat.w.org) for approval to update the string to be accessible as we a re post string freeze.

I'll push a fix to include lang attributes shortly.

[audrasjb]

Thanks @peterwilsoncc the new changeset looks good to me! 👍

[peterwilsoncc]

@tobifjellner has signed off on the change in the polyglots slack channel, see this tread.

[SergeyBiryukov]

Left a minor formatting suggestion, looks good to me otherwise 👍

[carolinan]

The lang attribute is not a requirement for the accessibility-ready tag: https://make.wordpress.org/themes/handbook/review/accessibility/required/