add: spacing styles for heading with annotation style in dust theme #636
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Preview changesYou can preview these changes by following the link below: I will update this comment with the latest preview links as you push more changes to this PR. Note The preview sites are created using WordPress Playground. You can add content, edit settings, and test the themes as you would on a real site, but please note that changes are not saved between sessions. |
troychaplin
requested review from
carolinan and
juanfra
and removed request for
carolinan
|
@troychaplin Thanks for your valuable PR. |
There was a problem hiding this comment.
Thank you, Troy!
This would be initially fixing the annotation padding for the dusk variation. The problem is that once saved, the CSS will be persistent and if you change the style variation then it'll affect how the annotation is viewed. The result would be creating this new problem:
Screen.Recording.2024-10-28.at.17.05.16.mov
| @@ -60,6 +60,7 @@ | |||
| "letterSpacing": "-0.18px", | |||
| "lineHeight": "1.5" | |||
| }, | |||
| "css": ".wp-block-heading.is-style-text-annotation {padding-bottom:0.15rem;}", | |||
There was a problem hiding this comment.
I still see a bit more spacing at the bottom. In my testing I believe approaching 0.1rem makes it look better. I'll defer to @beafialho to decide the value here.
There was a problem hiding this comment.
Ok, I'll make any additional changes necessary once we hear back
There was a problem hiding this comment.
@juanfra stepped away for a but, just following up on a few items. Are we still waiting for confirmation on this PR?
There was a problem hiding this comment.
@troychaplin thanks for coming back to this one. Unfortunately, as mentioned in the review, the PR will have the side effect of keeping/persisting the CSS once saved, affecting styles when changing variation. We need to find a solution that doesn't have this type of side effects. If we find it, we could confirm the padding-bottom of the annotation style for that variation in particular.
There was a problem hiding this comment.
@juanfra it sounds like it might be best to just close this PR and remove my name from the issue. I will still take some time to look at other solutions, but best to leave it unassigned in case someone else wants to take a look as well.
|
Closing pull request to pave the way for someone else who may have a new or better approach to solving this issue |
Description
Updated spacing as discussed in #605.
I set the bottom padding to 0.15rem instead of the originally suggested 0.2 based on a heading set in all caps still appearing to have more bottom space than the top.
Screenshots