Skip to content
This repository has been archived by the owner on Nov 18, 2024. It is now read-only.

add: spacing styles for heading with annotation style in dust theme #636

Closed
wants to merge 1 commit into from
Closed

add: spacing styles for heading with annotation style in dust theme #636

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions styles/03-dusk.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,7 @@
"letterSpacing": "-0.18px",
"lineHeight": "1.5"
},
"css": ".wp-block-heading.is-style-text-annotation {padding-bottom:0.15rem;}",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still see a bit more spacing at the bottom. In my testing I believe approaching 0.1rem makes it look better. I'll defer to @beafialho to decide the value here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I'll make any additional changes necessary once we hear back

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@juanfra stepped away for a but, just following up on a few items. Are we still waiting for confirmation on this PR?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@troychaplin thanks for coming back to this one. Unfortunately, as mentioned in the review, the PR will have the side effect of keeping/persisting the CSS once saved, affecting styles when changing variation. We need to find a solution that doesn't have this type of side effects. If we find it, we could confirm the padding-bottom of the annotation style for that variation in particular.

Copy link
Contributor Author

@troychaplin troychaplin Nov 4, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@juanfra it sounds like it might be best to just close this PR and remove my name from the issue. I will still take some time to look at other solutions, but best to leave it unassigned in case someone else wants to take a look as well.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, thank you Troy!

"blocks": {
"core/code": {
"color": {
Expand Down
Loading