WebAuthn changes required for production #169
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After #153 was merged, I attempted to enable it on WordPress.org, but ran into a number of problems.
buddypress_2fa_webauthn_credentials
and would createwordcamp_2fa_webauthn_credentials
too. Additionally it would rundbDelta()
every load on those sites for some reason.Use WebAuthn
as the alternate provider text on login 'aint great; Use the text "Use your security key" as the alternate provider text on the login screen. sjinks/wp-two-factor-provider-webauthn#468::is_available_for_user()
trigger SQL queries on each call, this is mostly our problem as we're filtering the primary providers, so the additional caching is maybe irrelevant. Ref: Enable WebAuthn plugin in wp-admin #153 (comment)See #114