Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebAuthn changes required for production #169

Merged
merged 7 commits into from
May 22, 2023
Merged

Conversation

dd32
Copy link
Member

@dd32 dd32 commented May 19, 2023

After #153 was merged, I attempted to enable it on WordPress.org, but ran into a number of problems.

See #114

@dd32 dd32 requested a review from iandunn May 19, 2023 04:55
@dd32
Copy link
Member Author

dd32 commented May 19, 2023

The WebAuthn plugin doesn't respect the revalidation process yet

Note: That's a two-pronged approach:

  • pre-ajax processing it aborts the request if the session isn't new enough
  • It wraps the UI with <fieldset disabled> which renders the buttons inoperable, but the links still load the disabled UI. Not pretty but works.

The WebAuthn plugin doesn't employ caching

I'm not sure this is strictly required, but as I'd already written the code before I realised that, I included it here.

@iandunn iandunn mentioned this pull request May 19, 2023
13 tasks
Copy link
Member

@iandunn iandunn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏻

class-wporg-webauthn-provider.php Show resolved Hide resolved
@dd32 dd32 merged commit d3aa77c into trunk May 22, 2023
@dd32 dd32 deleted the 153-production-requirements branch May 22, 2023 05:13
@dd32 dd32 added this to the MVP milestone May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants