[pull] master from Sarjuuk:master #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
Sarjuuk
force-pushed
the
master
branch
2 times, most recently
from
18c5a19 to
bf2e1bd
Compare
Sarjuuk
force-pushed
the
master
branch
3 times, most recently
from
7911e99 to
9f8c643
Compare
Sarjuuk
force-pushed
the
master
branch
2 times, most recently
from
18c39d0 to
6cabfd3
Compare
Sarjuuk
force-pushed
the
master
branch
2 times, most recently
from
93bc337 to
d22e90c
Compare
Sarjuuk
force-pushed
the
master
branch
3 times, most recently
from
6dca525 to
b3e8f5e
Compare
* use strings from globalstrings.lua to format time in item and spell tooltips * fixed item filter ItemCooldown * fixed timeAgo format * move item duration to correct position in tooltip
* get auras from creature_template_addon for tabs - npc: abilities - spell: used by npc
* fixed broken link to required event
* fix icon order for pet talents
* fixed rarity color for spells that create items
* removed old workaround for js date object creation
* kill an antique typo causing an error whenever a tooltip for a hearthstoneesque effect is displayed for Locale FR an RU
* also log POST data
* fixed resolving procSpells with a triggerSpell of 0 * spells are now always displayed in listview
* fixed help text referencing renamed parameter
* avoid using "echo" to write to CLI as php mistakes it for sent headers (see php-src #12303) * as we are using fwrite now, errors are written to STDERR instead of STDOUT * fixes an issue where reloading the config would cause "ini_set(): Session ini settings cannot be changed after headers have already been sent" to be spammed
* fixed several deprecation notices and warnings from MySQL8, most notably: - SQL_CALC_FOUND_ROWS: stopped using DBSimple::selectPage and query 'SELECT COUNT(*) ...' separately where needed - ON DUPLICATE KEY UPDATE ... VALUES(): use row alias for new values instead of VALUES function - boolean shorthands to long form (&& -> AND, etc)
* don't use 'delay' to calc added dps from ammunition
* do not display crafted item tooltip inside recipe tooltip if the craft spell doesn't create an item. (notably: enchantments were displaying enchantment scrolls) * always display reagent cost if set
* attempted cleanup in effect generation and template * display summon properties * display unit of effect value * fix spell effect layout, typos, missing tools, ...
* changed logic to not display required arena rating in tooltip or infobox if there are sources that don't require it. * also, should there be a difference in sources, display lowest required rating, not not highest.
* fix usage of generic search wildcards: ? * * only transform search form fields expected to be text * some cleanup (magic numbers to define, fn return types, nullsafe assignemnts)
* fix spawn point calculation on instance maps without dungeonmap entry (can't wait to see what breaks elsewhere)
* even more forgotten renames in help text * see 07e001e
* fix empty scaling bar * fix setting max level for scaling tooltips * fix displayed periodic power gain value for runic power and rage * attempt to fix spell coefficient calculation (dear god...) * append % sign to value for two more auras * display value per combo point
* fix invalid type error * simplyfy query building (there are no longer tables with an index named `entry`)
* fix totals query params after 481a3dc
* fix totals query. Rather treat original query as subquery than trying to modify it * fixes queries utilizing HAVING and GROUP BY
* reports can have 'null' subject (general bug reports, general feedback)
* fix icon formater: num/qty can be strings
* filter empty tabs before trying to display, case in point * do not always assign conditions tab if empty
* fix invalid return type in createConditionsForWeights()
* fix invalid return type in handleWeightscales() for action: delete
* fix index error in ArenaTeam member update query
* DROP COLUMN IF EXIST is MariaDB specific and should not be used.
* entirely switch over to write 'en' for locale 0 and accept both 'www' and 'en' for locale 0 when receiving
* do not use NULL on item stats as it prevents searching for an amount of 0 (except for stats that certain items just cant have) * fix stats from spells granting spell power and spell healing separately * define and use some item subclasses
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.1)
Can you help keep this open source service alive? 💖 Please sponsor : )