Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Floating windows default proportional position #1168

Closed
wants to merge 6 commits into from

Conversation

Mandarancio
Copy link

Hi,
I added the possibility to have the default position of floating windows expressed as a proportion of the working space size.
This will allow to better match the windows that have size proportional to the working area in particular in setup with multiple outputs.

recording.mp4

Thank you very much for this amazing project!

Cheers!

@YaLTeR
Copy link
Owner

YaLTeR commented Feb 24, 2025

I think the use-case you're showing can be solved by simply adding relative-to "top"?

@Mandarancio
Copy link
Author

Mandarancio commented Feb 24, 2025

I am not sure, it is true that with new bottom, top, left and right anchor options you could have centered windows on the side of the workspace, however you could not specify custom position: e.g. 5% from the left.

In the example the window has proportional width of 80% and it is placed 10% from the top left corner, so it is centered, however it could be as well not centered.

I do not know if I am explaining my self well.

I think the top, bottom, left and right option however could be as well great addition (but do not fill the same purpose IMO).

@YaLTeR
Copy link
Owner

YaLTeR commented Feb 24, 2025

It is not the goal of niri to support every possible configuration, so until there's some convincing use case for precise proportional positioning, I would prefer to not add it (the extra complexity is not worth it). I'd be fine with adding top/bottom/left/right for relative-to though.

@Mandarancio
Copy link
Author

Agree, close in favor of #1169

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants