Added top, left, bottom and right floating windows alignement #1169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YaLTeR
requested changes
Feb 27, 2025
resources/default-config.kdl
Outdated
Comment on lines
318
to
328
| // Example: drop down terminal from the bottom of the screen | ||
| // (This example rule is commented out with a "/-" in front.) | ||
| /-window-rule { | ||
| match app-id="dropdown" | ||
| open-focused true | ||
| open-floating true | ||
| default-floating-position x=0 y=0 relative-to="bottom" | ||
| default-window-height { proportion 0.500; } | ||
| default-column-width { proportion 0.8; } | ||
| } | ||
|
|
There was a problem hiding this comment.
Nah, let's leave this to the wiki, doesn't need to be in the default config.
Suggested change
| // Example: drop down terminal from the bottom of the screen | |
| // (This example rule is commented out with a "/-" in front.) | |
| /-window-rule { | |
| match app-id="dropdown" | |
| open-focused true | |
| open-floating true | |
| default-floating-position x=0 y=0 relative-to="bottom" | |
| default-window-height { proportion 0.500; } | |
| default-column-width { proportion 0.8; } | |
| } |
There was a problem hiding this comment.
Put it as a second example in the wiki section. Also probably if it's "drop down" then it should come from the top.
|
|
||
| binds { | ||
| // Keys consist of modifiers separated by + signs, followed by an XKB key name | ||
| // in the end. To find an XKB name for a particular key, you may use a program | ||
| // (This example rule is commented out with a "/-" in front.) |
There was a problem hiding this comment.
Suggested change
| // (This example rule is commented out with a "/-" in front.) |
src/layout/floating.rs
Outdated
Comment on lines
1221
to
1226
| if relative_to == RelativeTo::Top || relative_to == RelativeTo::Bottom { | ||
| pos.x = area.size.w / 2.0 - size.w / 2.0 - pos.x | ||
| } | ||
| if relative_to == RelativeTo::Left || relative_to == RelativeTo::Right { | ||
| pos.y = area.size.h / 2.0 - size.h / 2.0 - pos.y | ||
| } |
There was a problem hiding this comment.
I'd say these should have + pos.x and + pos.y respectively, rather than -.
wiki/Configuration:-Window-Rules.md
Outdated
| @@ -609,10 +609,11 @@ Afterward, the window will remember its last floating position. | |||
| By default, new floating windows open at the center of the screen, and windows from the tiling layout open close to their visual screen position. | |||
|
|
|||
| The position uses logical coordinates relative to the working area. | |||
| By default, they are relative to the top-left corner of the working area, but you can change this by setting `relative-to` to one of these values: `top-left`, `top-right`, `bottom-left`, `bottom-right`. | |||
| By default, they are relative to the top-left corner of the working area, but you can change this by setting `relative-to` to one of these values: `top-left`, `top-right`, `bottom-left`, `bottom-right`, `top`, `bottom`, `left` or `right`. | |||
There was a problem hiding this comment.
Suggested change
| By default, they are relative to the top-left corner of the working area, but you can change this by setting `relative-to` to one of these values: `top-left`, `top-right`, `bottom-left`, `bottom-right`, `top`, `bottom`, `left` or `right`. | |
| By default, they are relative to the top-left corner of the working area, but you can change this by setting `relative-to` to one of these values: `top-left`, `top-right`, `bottom-left`, `bottom-right`, `top`, `bottom`, `left`, or `right`. |
wiki/Configuration:-Window-Rules.md
Outdated
|
|
||
| For example, if you have a bar at the top, then `x=0 y=0` will put the top-left corner of the window directly below the bar. | ||
| If instead you write `x=0 y=0 relative-to="top-right"`, then the top-right corner of the window will align with the top-right corner of the workspace, also directly below the bar. | ||
| When only one side is secified (e.g. top) the window will allign to the center of that side. |
There was a problem hiding this comment.
Suggested change
| When only one side is secified (e.g. top) the window will allign to the center of that side. | |
| When only one side is specified (e.g. top) the window will align to the center of that side. |
|
@YaLTeR : thank you for the review. Updated with your suggestions! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #1168 instead of adding the relative position I added 4 new options for the alignment of floating windows to the side of the screen.
recording.b.mp4