feat: add ObliviousLRUCache with delete functionality #162
Conversation
trivikr
changed the title
There was a problem hiding this comment.
Hello @trivikr, thanks for this new PR. I have added some comments on this review. Have a good day.
| */ | ||
| import {IArrayLikeConstructor} from './utils/types'; | ||
|
|
||
| export default class ObliviousLRUCache<K, V> implements Iterable<[K, V]> { |
There was a problem hiding this comment.
I may be wrong but I think you can import the LRUCache class in this definition file and make this class definition extends it, no?
| setpop(key: K, value: V): {evicted: boolean, key: K, value: V}; | ||
| get(key: K): V | undefined; | ||
| peek(key: K): V | undefined; | ||
| remove(key: K): this; |
There was a problem hiding this comment.
And probably return boolean, based on next comment.
| } | ||
|
|
||
| if (this.head === pointer && this.tail === pointer) { | ||
| this.clear(); |
There was a problem hiding this comment.
Using #.clear here will reallocate the #.items object. Resetting head, tail and size to 0 should do the trick? Your condition can be simplified to this.size === 1 to be more performant if I understand the problem correctly.
| * @param {any} key - Key. | ||
| * @return {undefined} | ||
| */ | ||
| ObliviousLRUCache.prototype.delete = function(key) { |
There was a problem hiding this comment.
This method could a boolean indicating whether an item was delete, like the ES6 Map does, no?
| @@ -215,8 +216,52 @@ function makeTests(Cache, name) { | |||
|
|
|||
| assert.deepStrictEqual(entries, Array.from(cache.entries())); | |||
| }); | |||
|
|
|||
| if (name === 'ObliviousLRUCache') { | |||
| it('should be possible to delete keys from a LRU cache.', function() { | |||
There was a problem hiding this comment.
I am wondering whether a rolling test should be done? Like add 2 remove 1, in a loop of ~10 items for a cache of ~4-5 capacity.
|
Any update on this @trivikr? |
|
Superceded by #173 |
Fixes: #143
This PR creates ObliviousLRUCache with
deletefunctionality.Changes done:
deletefunctionality using a PointerArray to store deleted pointers.