Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change(ci): Updates dependabot.yml #8433

Merged
merged 4 commits into from
May 3, 2024
Merged

change(ci): Updates dependabot.yml #8433

merged 4 commits into from
May 3, 2024

Conversation

arya2
Copy link
Contributor

@arya2 arya2 commented Apr 24, 2024

Motivation

We want dependabot to update ECC dependencies separately from other production dependencies. This was working before, it seems it stopped working mid-October. I'm not sure if this PR will fix the issue either, but it updates the groups to look more like the examples in the dependabot config docs.

Related to #8431.

PR Author Checklist

Check before marking the PR as ready for review:

  • Will the PR name make sense to users?
  • Does the PR have a priority label?
  • Have you added or updated tests?
  • Is the documentation up to date?
For significant changes:
  • [x Is there a summary in the CHANGELOG?
  • Can these changes be split into multiple PRs?

If a checkbox isn't relevant to the PR, mark it as done.

Solution

  • Refactors patterns and exclude-patterns in the groups to pattern items instead of single big patterns

Testing

Merge this and see if Dependabot opens an ECC group update?

Review

Anyone can review.

Reviewer Checklist

Check before approving the PR:

  • Does the PR scope match the ticket?
  • Are there enough tests to make sure it works? Do the tests cover the PR motivation?
  • Are all the PR blockers dealt with?
    PR blockers can be dealt with in new tickets or PRs.

And check the PR Author checklist is complete.

@arya2 arya2 added A-dependencies Area: Dependency file updates A-devops Area: Pipelines, CI/CD and Dockerfiles P-Medium ⚡ labels Apr 24, 2024
@arya2 arya2 self-assigned this Apr 24, 2024
@arya2 arya2 requested a review from a team as a code owner April 24, 2024 00:51
@arya2 arya2 requested review from oxarbitrage and removed request for a team April 24, 2024 00:51
@github-actions github-actions bot added the C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG label Apr 24, 2024
Copy link
Contributor

@oxarbitrage oxarbitrage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, thnaks!

@arya2
Copy link
Contributor Author

arya2 commented Apr 30, 2024

@gustavovalverde any idea why the windows tests aren't running or being skipped?

@mpguerra mpguerra merged commit c4c04c2 into main May 3, 2024
91 checks passed
@mpguerra mpguerra deleted the fix-dependabot-groups branch May 3, 2024 07:40
@mpguerra
Copy link
Contributor

mpguerra commented May 3, 2024

I decided to admin merge this one in the end, was just waiting for windows tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-dependencies Area: Dependency file updates A-devops Area: Pipelines, CI/CD and Dockerfiles C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG P-Medium ⚡
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update dependabot groups to open PRs for ECC dependency updates separately
3 participants