-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
change(ci): Updates dependabot.yml #8433
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arya2
added
A-dependencies
Area: Dependency file updates
A-devops
Area: Pipelines, CI/CD and Dockerfiles
P-Medium ⚡
labels
Apr 24, 2024
github-actions
bot
added
the
C-trivial
Category: A trivial change that is not worth mentioning in the CHANGELOG
label
Apr 24, 2024
oxarbitrage
approved these changes
Apr 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me, thnaks!
arya2
force-pushed
the
fix-dependabot-groups
branch
from
April 25, 2024 16:30
eef788e
to
e5b2d8b
Compare
@gustavovalverde any idea why the windows tests aren't running or being skipped? |
I decided to admin merge this one in the end, was just waiting for windows tests |
This was referenced May 3, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-dependencies
Area: Dependency file updates
A-devops
Area: Pipelines, CI/CD and Dockerfiles
C-trivial
Category: A trivial change that is not worth mentioning in the CHANGELOG
P-Medium ⚡
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We want dependabot to update ECC dependencies separately from other production dependencies. This was working before, it seems it stopped working mid-October. I'm not sure if this PR will fix the issue either, but it updates the groups to look more like the examples in the dependabot config docs.
Related to #8431.
PR Author Checklist
Check before marking the PR as ready for review:
For significant changes:
If a checkbox isn't relevant to the PR, mark it as done.
Solution
patterns
andexclude-patterns
in the groups to pattern items instead of single big patternsTesting
Merge this and see if Dependabot opens an ECC group update?
Review
Anyone can review.
Reviewer Checklist
Check before approving the PR:
PR blockers can be dealt with in new tickets or PRs.
And check the PR Author checklist is complete.