-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expand draft to use dns-scoping & create DNS-01 #34
Conversation
* Update Amir's Company
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm really excited for this next version of the document. A few minor suggestions and line-edits:
Co-authored-by: Aaron Gable <[email protected]>
…eration, reference kid in introduction
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Amir for all of your work getting this incorporated! It is looking great!
I will make another pass on formatting and final flow once the few comments are addressed. Feel free to push back on anything.
draft-ietf-acme-dns-account-01.mkd
Outdated
_NODE NAME: _acme-challenge_* | ||
Reference: This document | ||
~~~ | ||
The first 10 bytes were picked as a tradeoff: the value needs to be short enough to not significantly impact DNS record and response size, long enough to provide sufficient probability of collision avoidance across ACME accounts, and just the right size to have Base32 require no padding. As the algorithm is used for a uniform distribution of inputs, and not for integrity, we do not consider the trimming a security issue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The main length concern was to make sure we didn't place additional pressure on the max length of DNS names (253) and make the challenge unusable for abnormally large names. (Statistically there are very very few when I ran this against Censys many years ago.)
I don't think we were too concerned about record size or response size, but it is fine to keep that in.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think by record size we meant the label size. The thing is, 253 is the soft limit I believe right? Else it just gets fragmented and forced into TCP?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've clarified this a bit now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The max valid length of a DNS name is 253 characters. The max label length is 63. So the full sha256 digest could fit into a base32 encoded label, but it would make more DNS names theoretically not be able to use this challenge.
https://devblogs.microsoft.com/oldnewthing/20120412-00/?p=7873
Certainly smaller responses in general are always preferred to avoid issues with fragmentation attacks.
https://www.ietf.org/archive/id/draft-ietf-dnsop-avoid-fragmentation-16.html
Co-authored-by: James Kasten <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is a great step forward. Happy to land this and do more iterations after as necessary.
No description provided.