Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expand draft to use dns-scoping & create DNS-01 #34
Expand draft to use dns-scoping & create DNS-01 #34
Changes from 40 commits
23cf066
ca38d9d
ca6ef16
17dfe71
19e266f
c95a7d1
9a6ea88
2fe6bbd
9a0b41a
399a19f
9e0d3f2
f7b1fa9
4eadab4
705bb5f
a4cd68c
488c8e8
cc02509
19faa97
573b8d6
1a7e22b
9e80b67
67073ce
44103a2
d70c0db
c74f709
90edc64
552ea74
431eab8
b3e3d23
cf8cc33
909e5c8
ef643f1
d42963e
914111a
f803417
967b7d2
d8eec9c
d0e853f
3f62aa7
7d10468
4b2bcdc
417aee4
a383daa
81330fb
b27ebeb
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The main length concern was to make sure we didn't place additional pressure on the max length of DNS names (253) and make the challenge unusable for abnormally large names. (Statistically there are very very few when I ran this against Censys many years ago.)
I don't think we were too concerned about record size or response size, but it is fine to keep that in.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think by record size we meant the label size. The thing is, 253 is the soft limit I believe right? Else it just gets fragmented and forced into TCP?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've clarified this a bit now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The max valid length of a DNS name is 253 characters. The max label length is 63. So the full sha256 digest could fit into a base32 encoded label, but it would make more DNS names theoretically not be able to use this challenge.
https://devblogs.microsoft.com/oldnewthing/20120412-00/?p=7873
Certainly smaller responses in general are always preferred to avoid issues with fragmentation attacks.
https://www.ietf.org/archive/id/draft-ietf-dnsop-avoid-fragmentation-16.html