Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Grade endpoints fix #134

Merged
merged 2 commits into from
Dec 7, 2024
Merged

Grade endpoints fix #134

merged 2 commits into from
Dec 7, 2024

Conversation

ronaldhej
Copy link
Contributor

@ronaldhej ronaldhej commented Dec 6, 2024 •
edited
Loading

Description

Added orgId to grade endpoints urls so that the auth policy can read it
Updated relevant tests

Related issues

Unauthorized access despite having the correct token and credentials

Checklist

  • My code is in the right place.
  • My code fully addresses the issue I was working on.
  • I have added appropriate tests and error handling.
  • My code follows the style guidelines.
  • I have added relevant comments explaining the purpose and function of my code (if necessary).
  • I have created a pull request and notified the teams.

LokeSGJ
LokeSGJ approved these changes Dec 6, 2024
View reviewed changes
Copy link
Contributor

@LokeSGJ LokeSGJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@LokeSGJ LokeSGJ merged commit 6917c9c into main Dec 7, 2024
1 check passed
@LokeSGJ LokeSGJ deleted the grade-endpoints-fix branch December 7, 2024 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LokeSGJ LokeSGJ LokeSGJ approved these changes

@DanielRBech DanielRBech DanielRBech approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ronaldhej @DanielRBech @LokeSGJ