-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pictograms #98
Pictograms #98
Conversation
…d antiforgery initial setup
…nd pictogram model, added fileutil for getting a IFormFile by filepath
…inding them due to incompatibility between multipart forms and mapping to DTOs
…ograms to make it easier to test endpoints in between container restarts
…d antiforgery initial setup
…nd pictogram model, added fileutil for getting a IFormFile by filepath
…inding them due to incompatibility between multipart forms and mapping to DTOs
…ograms to make it easier to test endpoints in between container restarts
# Conflicts: # Dockerfile # GirafAPI/Data/GirafDbContext.cs # GirafAPI/GirafAPI.csproj # GirafAPI/Program.cs
Removed config files accidentally added
…ly save the db additions
…w one every time Added the url to mapping
Getting activities now includes the associated pictogram info if one is assigned to it
Removed accidentally added pictograms folder
Removed accidentally added migration directory
Removed accidentally added migrations directory
# Conflicts: # GirafAPI/Data/Migrations/20241114212357_initialMigration.Designer.cs # GirafAPI/Data/Migrations/20241114212357_initialMigration.cs # GirafAPI/Data/Migrations/GirafDbContextModelSnapshot.cs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks pretty good overall, only minor comments. I'm not 100% sure what the docker changes do and why they were made as part of this PR, but I trust that it still works so I'm giving you the approve 😄
@@ -26,6 +26,8 @@ | |||
</ItemGroup> | |||
|
|||
<ItemGroup> | |||
<Folder Include="DataMigrations\" /> | |||
<Folder Include="Data\Migrations\" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is one of these an unnecessary duplicate?
Description
Pictograms can now be created, deleted and data about them can be fetched by id or by organisation
The pictograms are statically served on the backend at the url outlined in the pictogramDTO
Pictograms can be assigned to activities and if an activity has an assigned pictogram, its info will be included
Related issues
#34
Checklist