feat: apply prettier to all supported file types
#516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
G-Rath
requested review from
eoinkelly,
lukeify,
halles,
joshmcarthur,
robotdana,
robramsaynz,
JacobBriggsAckama,
brooke-m and
hopkincame
lukeify
approved these changes
Nov 24, 2023
joshmcarthur
approved these changes
Nov 26, 2023
robotdana
approved these changes
Nov 30, 2023
G-Rath
added a commit
that referenced
this pull request
Jan 11, 2024
While rebasing #466 after #516 was landed I learned that I had actually mucked up my erb for the GitHub Actions workflow - this was only picked up because it was invalid YAML so Prettier errored. To help avoid mistakes in future, this introduces running [`actionlint`](https://github.com/rhysd/actionlint) as part of our _template_ CI. Since doing so means that `bin/ci-run` now includes a tool that isn't in our CI workflow, this PR can also be seen as the initial nudge towards a possible future with a very different approach to `bin/ci-run` (including not having it at all) that I've been wanting to bring up for discussion for a bit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We originally limited the files we applied
prettierto a subset (which I think is really just "not yaml"?) when we first started using it, but I think nowdays we're all very comfortable with it and we don't have anything else linting our YAML so lets starting doing that