refactor: use time info in Kalman vertex fit

[felix-russo]

Since we introduced the time coordinate in tracking, I propose to the same in the Kalman vertex fitter now that the Jacobians of HelicalTrackLinearizer are filled entirely.

Starting to factor this out, blocked by:

• refactor: set full vertex covariance after seeding #2707
• refactor: KalmanVertexUpdater #2708

[codecov]

Codecov Report

Attention: 86 lines in your changes are missing coverage. Please review.

Comparison is base (37a2f9e) 49.54% compared to head (989cebd) 49.61%.
Report is 1 commits behind head on main.

Files	Patch %	Lines
...ore/include/Acts/Vertexing/KalmanVertexUpdater.ipp	26.21%	4 Missing and 72 partials ⚠️
...clude/Acts/Vertexing/AdaptiveMultiVertexFinder.ipp	0.00%	4 Missing ⚠️
...nclude/Acts/Vertexing/TrackDensityVertexFinder.ipp	0.00%	0 Missing and 3 partials ⚠️
Core/include/Acts/TrackFitting/KalmanFitter.hpp	33.33%	0 Missing and 2 partials ⚠️
...clude/Acts/Vertexing/AdaptiveMultiVertexFitter.ipp	0.00%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2544      +/-   ##
==========================================
+ Coverage   49.54%   49.61%   +0.06%     
==========================================
  Files         474      473       -1     
  Lines       26929    26922       -7     
  Branches    12425    12405      -20     
==========================================
+ Hits        13343    13357      +14     
- Misses       4749     4753       +4     
+ Partials     8837     8812      -25     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[github-actions]

📊: Physics performance monitoring for 989cebd

Full contents
🟥 summary not found!

[felix-russo]

Encountered some changes in physmon, the PR seems to improve performance for AMVF orthogonal

but deteriorate performance for AMVF (+grid seeder) seeded

[andiwand]

looks good to me. I think the performance needs to be studied in a more global setting anyway. I am fine with a small loss

[acts-project-service]

🔴 Athena integration test results [1b4f454]

🔴 Some tests have failed!

Please investigate the pipeline!

status	job
🔴	run_workflow_tests_run2_data
🟢	run_unit_tests
🟢	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsWorkflow.sh
🟢	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateTracks.sh
🟢	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateActsCoreSpacePoints.sh
🟢	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateActsSpacePoints.sh
🟢	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateSeeds.sh
🟢	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateOrthogonalSeeds.sh
🟢	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateClusters.sh
🟢	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsPersistifyEDM.sh
🟢	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsKfRefitting.sh
🟢	run_ci_tests: python3 ../athena/Tracking/Acts/ActsGeometry/test/ActsExtrapolationAlgTest.py
🟢	run_ci_tests: python3 ../athena/Tracking/Acts/ActsGeometry/test/ActsITkTest.py
🔴	run_workflow_tests_run4_mc
🔴	run_workflow_tests_run3_mc
🔴	run_workflow_tests_run3_data

[andiwand]

can you resolve the conflict @felix-russo ?

[felix-russo]

Closing in favor of #2751