Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: error handling in the vertexing algorithms #2649

Merged
merged 29 commits into from
Nov 17, 2023

Merge branch 'main' into pass-error-message-amvfitter

71149e8
Select commit
Loading
Failed to load commit list.
Merged

refactor!: error handling in the vertexing algorithms #2649

Merge branch 'main' into pass-error-message-amvfitter
71149e8
Select commit
Loading
Failed to load commit list.
This check has been archived and is scheduled for deletion. Learn more about checks retention
Codecov / codecov/project succeeded Nov 17, 2023 in 1s

49.63% (-0.08%) compared to 2097b7a

View this Pull Request on Codecov

49.63% (-0.08%) compared to 2097b7a

Details

Codecov Report

Attention: 55 lines in your changes are missing coverage. Please review.

Comparison is base (2097b7a) 49.70% compared to head (71149e8) 49.63%.

Files Patch % Lines
...clude/Acts/Vertexing/AdaptiveMultiVertexFitter.ipp 0.00% 27 Missing and 8 partials ⚠️
...re/include/Acts/Vertexing/ImpactPointEstimator.ipp 0.00% 7 Missing ⚠️
...e/include/Acts/Vertexing/IterativeVertexFinder.ipp 0.00% 2 Missing and 2 partials ⚠️
...clude/Acts/Vertexing/AdaptiveMultiVertexFinder.ipp 0.00% 1 Missing and 2 partials ⚠️
...clude/Acts/Vertexing/AdaptiveMultiVertexFinder.hpp 66.66% 0 Missing and 1 partial ⚠️
...clude/Acts/Vertexing/AdaptiveMultiVertexFitter.hpp 0.00% 0 Missing and 1 partial ⚠️
...include/Acts/Vertexing/FullBilloirVertexFitter.hpp 87.50% 1 Missing ⚠️
...include/Acts/Vertexing/FullBilloirVertexFitter.ipp 0.00% 1 Missing ⚠️
...re/include/Acts/Vertexing/ImpactPointEstimator.hpp 83.33% 0 Missing and 1 partial ⚠️
...e/include/Acts/Vertexing/IterativeVertexFinder.hpp 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2649      +/-   ##
==========================================
- Coverage   49.70%   49.63%   -0.08%     
==========================================
  Files         474      474              
  Lines       26892    26941      +49     
  Branches    12376    12415      +39     
==========================================
+ Hits        13368    13372       +4     
- Misses       4710     4746      +36     
- Partials     8814     8823       +9

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov