Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: set full vertex covariance after seeding #2707

Merged
merged 6 commits into from
Nov 21, 2023

Conversation

felix-russo
Copy link
Contributor

@felix-russo felix-russo commented Nov 21, 2023

Sets the also the time covariance of the vertex after seeding. Needed to include time consistently.

Should not change physmon, let's see!

@github-actions github-actions bot added Component - Core Affects the Core module Component - Examples Affects the Examples module Vertexing labels Nov 21, 2023
Copy link

codecov bot commented Nov 21, 2023

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (a5aaea0) 49.53% compared to head (1ae8b06) 49.53%.

Files Patch % Lines
...nclude/Acts/Vertexing/TrackDensityVertexFinder.ipp 0.00% 0 Missing and 5 partials ⚠️
...Acts/Vertexing/AdaptiveGridDensityVertexFinder.ipp 72.72% 0 Missing and 3 partials ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2707   +/-   ##
=======================================
  Coverage   49.53%   49.53%           
=======================================
  Files         474      474           
  Lines       26939    26944    +5     
  Branches    12433    12435    +2     
=======================================
+ Hits        13345    13348    +3     
  Misses       4751     4751           
- Partials     8843     8845    +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@LuisFelipeCoelho LuisFelipeCoelho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@acts-project-service
Copy link
Collaborator

acts-project-service commented Nov 21, 2023

@paulgessinger paulgessinger added this to the next milestone Nov 21, 2023
@paulgessinger
Copy link
Member

ATLAS output seems fine.

@felix-russo
Copy link
Contributor Author

Can we get this in then? @paulgessinger

@kodiakhq kodiakhq bot merged commit eb7d11b into acts-project:main Nov 21, 2023
49 checks passed
@felix-russo felix-russo deleted the set-fullCovariance branch November 22, 2023 10:23
@paulgessinger paulgessinger modified the milestones: next, v31.1.0 Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component - Core Affects the Core module Component - Examples Affects the Examples module Vertexing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants