Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Flag for secondary vertex labeling in Pythia8ProcessGenerator #2989

Merged
merged 5 commits into from
Feb 27, 2024

Conversation

andiwand
Copy link
Contributor

Currently we label secondary vertices in Pythia8ProcessGenerator that are for example products of prompt decays. I flag this labeling procedure and change the default to assign everything to the primary vertex.

@andiwand andiwand added this to the next milestone Feb 26, 2024
@github-actions github-actions bot added the Component - Examples Affects the Examples module label Feb 26, 2024
Copy link

codecov bot commented Feb 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 48.73%. Comparing base (e06342c) to head (3edefb7).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2989   +/-   ##
=======================================
  Coverage   48.73%   48.73%           
=======================================
  Files         493      493           
  Lines       28943    28943           
  Branches    13776    13776           
=======================================
  Hits        14106    14106           
  Misses       4924     4924           
  Partials     9913     9913           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andiwand
Copy link
Contributor Author

Since this is changing the IDs of the particles and we sort particles based on their IDs, I suspect that the simulation RNG changes a bit since we roll the dice differently for some particles now

@github-actions github-actions bot added Infrastructure Changes to build tools, continous integration, ... Changes Performance labels Feb 26, 2024
…Pythia8ProcessGenerator.hpp

Co-authored-by: Paul Gessinger <[email protected]>
@andiwand andiwand changed the title fix: Flag for secondary vertex labelling in Pythia8ProcessGenerator fix: Flag for secondary vertex labeling in Pythia8ProcessGenerator Feb 27, 2024
@kodiakhq kodiakhq bot merged commit 1cc1759 into acts-project:main Feb 27, 2024
57 checks passed
@andiwand andiwand deleted the fix-pythia-secondary-vertices branch February 27, 2024 08:38
@acts-project-service
Copy link
Collaborator

acts-project-service commented Feb 27, 2024

🔴 Athena integration test results [1cc1759]

Build job with this PR failed!

Please investigate the build job for the pipeline!

@acts-project-service acts-project-service added the Breaks Athena build This PR breaks the Athena build label Feb 27, 2024
kodiakhq bot pushed a commit that referenced this pull request Feb 28, 2024
Instead of decomposing the `Barcode` in primary and secondary we can set the other components to zero and use it as a vertex ID.

It would be handy to have an actual vertex ID and a truth vertex EDM but this is a story for another day.

blocked by
- #2989
@paulgessinger paulgessinger modified the milestones: next, v33.0.0 Mar 6, 2024
@paulgessinger paulgessinger removed the Breaks Athena build This PR breaks the Athena build label Mar 6, 2024
EleniXoch pushed a commit to EleniXoch/acts that referenced this pull request May 6, 2024
…cts-project#2989)

Currently we label secondary vertices in `Pythia8ProcessGenerator` that are for example products of prompt decays. I flag this labeling procedure and change the default to assign everything to the primary vertex.
EleniXoch pushed a commit to EleniXoch/acts that referenced this pull request May 6, 2024
…project#2970)

Instead of decomposing the `Barcode` in primary and secondary we can set the other components to zero and use it as a vertex ID.

It would be handy to have an actual vertex ID and a truth vertex EDM but this is a story for another day.

blocked by
- acts-project#2989
asalzburger pushed a commit to asalzburger/acts that referenced this pull request May 21, 2024
…cts-project#2989)

Currently we label secondary vertices in `Pythia8ProcessGenerator` that are for example products of prompt decays. I flag this labeling procedure and change the default to assign everything to the primary vertex.
asalzburger pushed a commit to asalzburger/acts that referenced this pull request May 21, 2024
…project#2970)

Instead of decomposing the `Barcode` in primary and secondary we can set the other components to zero and use it as a vertex ID.

It would be handy to have an actual vertex ID and a truth vertex EDM but this is a story for another day.

blocked by
- acts-project#2989
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes Performance Component - Examples Affects the Examples module Infrastructure Changes to build tools, continous integration, ...
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants