-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Flag for secondary vertex labeling in Pythia8ProcessGenerator
#2989
fix: Flag for secondary vertex labeling in Pythia8ProcessGenerator
#2989
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2989 +/- ##
=======================================
Coverage 48.73% 48.73%
=======================================
Files 493 493
Lines 28943 28943
Branches 13776 13776
=======================================
Hits 14106 14106
Misses 4924 4924
Partials 9913 9913 ☔ View full report in Codecov by Sentry. |
📊: Physics performance monitoring for 3edefb7physmon summary
|
Since this is changing the IDs of the particles and we sort particles based on their IDs, I suspect that the simulation RNG changes a bit since we roll the dice differently for some particles now |
…cts into fix-pythia-secondary-vertices
Examples/Algorithms/GeneratorsPythia8/ActsExamples/Generators/Pythia8ProcessGenerator.hpp
Outdated
Show resolved
Hide resolved
…Pythia8ProcessGenerator.hpp Co-authored-by: Paul Gessinger <[email protected]>
Pythia8ProcessGenerator
Pythia8ProcessGenerator
Instead of decomposing the `Barcode` in primary and secondary we can set the other components to zero and use it as a vertex ID. It would be handy to have an actual vertex ID and a truth vertex EDM but this is a story for another day. blocked by - #2989
…cts-project#2989) Currently we label secondary vertices in `Pythia8ProcessGenerator` that are for example products of prompt decays. I flag this labeling procedure and change the default to assign everything to the primary vertex.
…project#2970) Instead of decomposing the `Barcode` in primary and secondary we can set the other components to zero and use it as a vertex ID. It would be handy to have an actual vertex ID and a truth vertex EDM but this is a story for another day. blocked by - acts-project#2989
…cts-project#2989) Currently we label secondary vertices in `Pythia8ProcessGenerator` that are for example products of prompt decays. I flag this labeling procedure and change the default to assign everything to the primary vertex.
…project#2970) Instead of decomposing the `Barcode` in primary and secondary we can set the other components to zero and use it as a vertex ID. It would be handy to have an actual vertex ID and a truth vertex EDM but this is a story for another day. blocked by - acts-project#2989
Currently we label secondary vertices in
Pythia8ProcessGenerator
that are for example products of prompt decays. I flag this labeling procedure and change the default to assign everything to the primary vertex.