Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Flag for secondary vertex labeling in Pythia8ProcessGenerator #2989

Merged
merged 5 commits into from
Feb 27, 2024
Merged

fix: Flag for secondary vertex labeling in Pythia8ProcessGenerator #2989

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
4b4193e
dont label secondary vertices with pythia
andiwand Feb 26, 2024
bff42e4
Merge branch 'main' into fix-pythia-secondary-vertices
andiwand Feb 26, 2024
c76a870
update ref
andiwand Feb 26, 2024
54ef81b
Merge branch 'fix-pythia-secondary-vertices' of github.com:andiwand/a…
andiwand Feb 26, 2024
3edefb7
Update Examples/Algorithms/GeneratorsPythia8/ActsExamples/Generators/…
andiwand Feb 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file modified CI/physmon/reference/performance_ambi_ttbar.root
View file
Open in desktop
Binary file not shown.
Binary file modified CI/physmon/reference/performance_amvf_gridseeder_ttbar_hist.root
View file
Open in desktop
Binary file not shown.
Binary file modified CI/physmon/reference/performance_amvf_ttbar_hist.root
View file
Open in desktop
Binary file not shown.
Binary file modified CI/physmon/reference/performance_ckf_ttbar.root
View file
Open in desktop
Binary file not shown.
Binary file modified CI/physmon/reference/performance_seeding_ttbar.root
View file
Open in desktop
Binary file not shown.
Binary file modified CI/physmon/reference/tracksummary_ckf_ttbar_hist.root
View file
Open in desktop
Binary file not shown.
2 changes: 1 addition & 1 deletion Examples/Algorithms/GeneratorsPythia8/ActsExamples/Generators/Pythia8ProcessGenerator.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ ActsExamples::SimParticleContainer ActsExamples::Pythia8Generator::operator()(
// ensure particle identifier component is non-zero
particleId.setParticle(1u + generated.size());
// only secondaries have a defined vertex position
if (genParticle.hasVertex()) {
if (m_cfg.labelSecondaries && genParticle.hasVertex()) {
// either add to existing secondary vertex if exists or create new one
// TODO can we do this w/o the manual search and position check?
auto it = std::find_if(
Expand Down
4 changes: 4 additions & 0 deletions Examples/Algorithms/GeneratorsPythia8/ActsExamples/Generators/Pythia8ProcessGenerator.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,10 @@ class Pythia8Generator : public EventGenerator::ParticlesGenerator {
bool printShortEventListing = false;
/// Let pythia print detailed event info
bool printLongEventListing = false;
/// Turn on/off the labeling of secondary vertices
/// TODO this is essentially broken as the current code will label any kind
/// of decay as secondary
bool labelSecondaries = false;
};

Pythia8Generator(const Config& cfg, Acts::Logging::Level lvl);
Expand Down
2 changes: 1 addition & 1 deletion Examples/Python/tests/root_file_hashes.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
test_pythia8__pythia8_particles.root: 082eb3dbf142929df28acfec48d61f260e132cb103966d143f430eeeda89daa1
test_pythia8__pythia8_particles.root: 79fa44dadc3193c9349c108c7a784d6121d343f88e8059ca11eed442ab1d49db
test_fatras__particles_simulation.root: 4ce0feb0ecb234143f418789a7a0d377f4a653d529c49bf999dda1878c50cee1
test_fatras__hits.root: 2e47d9ba55fa1b377f70c361107fe811e9880d14c42cb3d7a9cd4616a6f33a54
test_geant4__particles_simulation.root: 29fb3ed0c9ea48bc64cb6e4a83f4f6ca535415ab7a71051ca385943ce3dea31f
Expand Down
Loading