Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Ubuntu 24.04 machine with LLVM 19 #129

Merged
merged 1 commit into from
Dec 3, 2024
Merged

Conversation

stephenswat
Copy link
Member

LLVM 19 adds the new (and very conveniently named) -Wmissing-template-arg-list-after-template-kw warning flag which fires a lot on the existing ACTS code. The new version of OneAPI is based on this version of LLVM, which is causing us a bit of grief in e.g. acts-project/traccc#793. In order to resolve this issue I want to add an LLVM 19 build to ACTS.

@stephenswat stephenswat added the enhancement New feature or request label Dec 3, 2024
@stephenswat stephenswat force-pushed the feat/ubuntu2404_clang19 branch from 37fc4e5 to 26a9dc7 Compare December 3, 2024 14:07
LLVM 19 adds the new (and very conveniently named)
`-Wmissing-template-arg-list-after-template-kw` warning flag which fires
a lot on the existing ACTS code. The new version of OneAPI is based on
this version of LLVM, which is causing us a bit of grief in e.g.
acts-project/traccc#793. In order to resolve
this issue I want to add an LLVM 19 build to ACTS.
@paulgessinger
Copy link
Member

paulgessinger commented Dec 3, 2024

We'd also need a dedicated downstream build of the dependencies to use this in the ACTS CI.

@stephenswat
Copy link
Member Author

We'd also need a dedicated downstream build of the dependencies to use this in the ACTS CI.

Out of curiosity, doesn't the ubuntu2204_clang image quite happily use the generic Ubuntu 22.04 dependencies here: https://github.com/acts-project/acts/blob/main/.github/workflows/builds.yml#L265?

Would the same not work for Ubuntu 24.04 with clang?

@paulgessinger
Copy link
Member

@stephenswat Yeah, you're right actually. We can try it in any case.

@stephenswat
Copy link
Member Author

@stephenswat Yeah, you're right actually. We can try it in any case.

Alright I'll give it a try then; thanks!

@stephenswat stephenswat merged commit bc0f3ff into main Dec 3, 2024
17 checks passed
@stephenswat stephenswat deleted the feat/ubuntu2404_clang19 branch December 3, 2024 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants