oneAPI 2025 / SYCL2020 Compatibility, main branch (2024.12.03.) #793
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krasznaa
added
cicd
krasznaa
commented
Dec 3, 2024
Comment on lines
+87
to
+92
| - name: Install dependencies | ||
| run: | | ||
| apt install -y zstd | ||
| curl --retry 5 --retry-delay 10 --output deps.tar.zst https://acts.web.cern.ch/ACTS/ci/ubuntu-24.04/deps.v6.tar.zst | ||
| tar -xf deps.tar.zst -C /usr/local --strip-components=1 | ||
| rm deps.tar.zst |
There was a problem hiding this comment.
@paulgessinger, I decided to download the tar file like this. I didn't quite understand why Acts is doing this in a much more complicated way... 🤔
krasznaa
force-pushed
the
SYCL2020-main-20241203
branch
from
20c62ab to
c55cb2c
Compare
|
Here are the problems I had compiling traccc with oneAPI recent snapshot (I used 2024/11/24). In acts: GlobalChiSquareFitter.hpp IIUC this code has changed (not a template anymore) but traccc refer to an older version that still uses it. In detray: bound_track_parameters.hpp That's all I can remember. |
stephenswat
added a commit
to acts-project/machines
that referenced
this pull request
Dec 3, 2024
LLVM 19 adds the new (and very conveniently named) `-Wmissing-template-arg-list-after-template-kw` warning flag which fires a lot on the existing ACTS code. The new version of OneAPI is based on this version of LLVM, which is causing us a bit of grief in e.g. acts-project/traccc#793. In order to resolve this issue I want to add an LLVM 19 build to ACTS.
stephenswat
added a commit
to acts-project/machines
that referenced
this pull request
Dec 3, 2024
LLVM 19 adds the new (and very conveniently named) `-Wmissing-template-arg-list-after-template-kw` warning flag which fires a lot on the existing ACTS code. The new version of OneAPI is based on this version of LLVM, which is causing us a bit of grief in e.g. acts-project/traccc#793. In order to resolve this issue I want to add an LLVM 19 build to ACTS.
stephenswat
added a commit
to acts-project/machines
that referenced
this pull request
Dec 3, 2024
LLVM 19 adds the new (and very conveniently named) `-Wmissing-template-arg-list-after-template-kw` warning flag which fires a lot on the existing ACTS code. The new version of OneAPI is based on this version of LLVM, which is causing us a bit of grief in e.g. acts-project/traccc#793. In order to resolve this issue I want to add an LLVM 19 build to ACTS.
krasznaa
force-pushed
the
SYCL2020-main-20241203
branch
from
c55cb2c to
cbfbd81
Compare
This required adding some code for downloading the externals from the appropriate Acts tar file.
krasznaa
force-pushed
the
SYCL2020-main-20241203
branch
from
cbfbd81 to
8bda176
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuing to peel off mergeable parts from #773.
These updates make it possible to build the project using oneAPI 2025.0.0.
sycl_language_example.syclinstead of fixing it. Since it was not serving any purpose anyway.<CL/sycl.hpp>-><sycl/sycl.hpp>andcl::sycl->::syclchanges in the code.