Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SYCL Track Finding, main branch (2025.01.09.) #811

Merged
merged 5 commits into from
Jan 10, 2025

Conversation

krasznaa
Copy link
Member

@krasznaa krasznaa commented Jan 9, 2025

With everything finally in place, this is a (hopefully) reviewable replacement of #773.

Unfortunately the code continues to not work on Intel GPUs, but for now I "solved" this by turning off the unit tests for the Intel platform. 😦

At least on an NVIDIA platform, the tests work as expected. 🥳

[bash][Legolas]:out > ./build/sycl-fp32/bin/traccc_test_sycl --gtest_filter="*Ckf*"
Running main() from /data/ssd-1tb/projects/traccc/traccc/out/build/sycl-fp32/_deps/googletest-src/googletest/src/gtest_main.cc
Note: Google Test filter = *Ckf*
[==========] Running 5 tests from 2 test suites.
[----------] Global test environment set-up.
[----------] 2 tests from SYCLCkfCombinatoricsTelescopeValidation/CkfCombinatoricsTelescopeTests
[ RUN      ] SYCLCkfCombinatoricsTelescopeValidation/CkfCombinatoricsTelescopeTests.Run/0
Created test queue on device: NVIDIA GeForce RTX 3080
WARNING: No entries in volume finder

Detector check: OK
[       OK ] SYCLCkfCombinatoricsTelescopeValidation/CkfCombinatoricsTelescopeTests.Run/0 (696 ms)
[ RUN      ] SYCLCkfCombinatoricsTelescopeValidation/CkfCombinatoricsTelescopeTests.Run/1
Created test queue on device: NVIDIA GeForce RTX 3080
WARNING: No entries in volume finder

Detector check: OK
[       OK ] SYCLCkfCombinatoricsTelescopeValidation/CkfCombinatoricsTelescopeTests.Run/1 (587 ms)
[----------] 2 tests from SYCLCkfCombinatoricsTelescopeValidation/CkfCombinatoricsTelescopeTests (1284 ms total)

[----------] 3 tests from SYCLCkfToyDetectorValidation/CkfToyDetectorTests
[ RUN      ] SYCLCkfToyDetectorValidation/CkfToyDetectorTests.Run/0
Created test queue on device: NVIDIA GeForce RTX 3080
WARNING: No entries in volume finder

Detector check: OK
[       OK ] SYCLCkfToyDetectorValidation/CkfToyDetectorTests.Run/0 (278 ms)
[ RUN      ] SYCLCkfToyDetectorValidation/CkfToyDetectorTests.Run/1
Created test queue on device: NVIDIA GeForce RTX 3080
WARNING: No entries in volume finder

Detector check: OK
[       OK ] SYCLCkfToyDetectorValidation/CkfToyDetectorTests.Run/1 (5096 ms)
[ RUN      ] SYCLCkfToyDetectorValidation/CkfToyDetectorTests.Run/2
Created test queue on device: NVIDIA GeForce RTX 3080
WARNING: No entries in volume finder

Detector check: OK
[       OK ] SYCLCkfToyDetectorValidation/CkfToyDetectorTests.Run/2 (5084 ms)
[----------] 3 tests from SYCLCkfToyDetectorValidation/CkfToyDetectorTests (10459 ms total)

[----------] Global test environment tear-down
[==========] 5 tests from 2 test suites ran. (11743 ms total)
[  PASSED  ] 5 tests.
[bash][Legolas]:out >

@krasznaa krasznaa added feature New feature or request sycl Changes related to SYCL labels Jan 9, 2025
Copy link
Member

@stephenswat stephenswat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for the most part, although we need to rework the way we handle kernel identifiers.

@beomki-yeo
Copy link
Contributor

The PR looks OK from my side... 👍

@krasznaa krasznaa force-pushed the SYCLTrackFinding-main-20250109 branch from ba57c60 to 8be7cba Compare January 10, 2025 06:42
Copy link
Member

@stephenswat stephenswat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 👍

@krasznaa krasznaa merged commit e7948f3 into acts-project:main Jan 10, 2025
29 checks passed
@krasznaa krasznaa deleted the SYCLTrackFinding-main-20250109 branch January 10, 2025 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request sycl Changes related to SYCL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants