-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SYCL Track Finding, main branch (2025.01.09.) #811
SYCL Track Finding, main branch (2025.01.09.) #811
Conversation
While also doing some final small fixes in the common track finding code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good for the most part, although we need to rework the way we handle kernel identifiers.
.../sycl/src/finding/combinatorial_kalman_filter_algorithm_constant_field_default_detector.sycl
Outdated
Show resolved
Hide resolved
...ycl/src/finding/combinatorial_kalman_filter_algorithm_constant_field_telescope_detector.sycl
Outdated
Show resolved
Hide resolved
The PR looks OK from my side... 👍 |
ba57c60
to
8be7cba
Compare
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. 👍
With everything finally in place, this is a (hopefully) reviewable replacement of #773.
Unfortunately the code continues to not work on Intel GPUs, but for now I "solved" this by turning off the unit tests for the Intel platform. 😦
At least on an NVIDIA platform, the tests work as expected. 🥳