Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed ESLint rule that prevents cross-component imports #1050

Merged
merged 3 commits into from
Oct 24, 2023
Merged

Fixed ESLint rule that prevents cross-component imports #1050

merged 3 commits into from
Oct 24, 2023

Conversation

carterworks
Copy link
Contributor

Description

This PR modifies our ESLint rules. It prevents things like the Identity component importing from the Personalization component.

Related Issue

Motivation and Context

The in-browser-messages has a few places that violate this rule that were not caught by ESLint, but should have been.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (non-breaking change which does not add functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA or I'm an Adobe employee.
  • I have made any necessary test changes and all tests pass.
  • I have run the Sandbox successfully.

@carterworks carterworks added the ignore-for-release Do not include this PR in release notes label Oct 11, 2023
@carterworks carterworks marked this pull request as ready for review October 11, 2023 21:12
@carterworks carterworks mentioned this pull request Oct 11, 2023
Merged
7 tasks
jonsnyder
jonsnyder approved these changes Oct 19, 2023
View reviewed changes
Copy link
Contributor

@jonsnyder jonsnyder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@carterworks carterworks merged commit fe0da27 into main Oct 24, 2023
1 check passed
@carterworks carterworks deleted the fix-eslint-restricted-imports-rule branch October 24, 2023 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shandilya3 shandilya3 shandilya3 approved these changes

@jonsnyder jonsnyder jonsnyder approved these changes

Assignees
No one assigned
Labels
ignore-for-release Do not include this PR in release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@carterworks @jonsnyder @shandilya3