Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

querystring #1070

Closed
wants to merge 2 commits into from
Closed

querystring #1070

wants to merge 2 commits into from

Conversation

shandilya3
Copy link
Collaborator

Description

Related Issue

Motivation and Context

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (non-breaking change which does not add functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA or I'm an Adobe employee.
  • I have made any necessary test changes and all tests pass.
  • I have run the Sandbox successfully.

@shandilya3 shandilya3 mentioned this pull request Oct 27, 2023
Merged
7 tasks
carterworks
carterworks approved these changes Oct 27, 2023
View reviewed changes
src/components/Personalization/in-app-message-actions/utils.js
@@ -11,6 +11,7 @@ governing permissions and limitations under the License.
*/
import { isNonEmptyArray, startsWith } from "../../../utils";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove line 14 and make this import { isNonEmptyArray, startsWith, queryString } from "../../../utils";

@carterworks carterworks mentioned this pull request Oct 27, 2023
Merged
@shandilya3
Copy link
Collaborator Author

taken care in 1070

@shandilya3 shandilya3 closed this Oct 27, 2023
@shandilya3 shandilya3 deleted the codeReviewFixPart3 branch October 27, 2023 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carterworks carterworks carterworks approved these changes

@jasonwaters jasonwaters Awaiting requested review from jasonwaters

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shandilya3 @carterworks