Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add README, test.properties files #2538

Merged
merged 4 commits into from
Apr 28, 2021
Merged

add README, test.properties files #2538

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
070e03c
add README, test.properties files
mara-ber Apr 23, 2021
fe31444
fix for minor issues
mara-ber Apr 25, 2021
121c9db
add describtion, change the layout
mara-ber Apr 27, 2021
b909488
fix for the minor issues in readme
mara-ber Apr 28, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions external/jacoco/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
Running External Jacoco tests locally
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add following part before this Running External Jacoco tests locally

External Jacoco Tests

Jacoco tests are part of the external third-party application tests that help verify that the Adoptium binaries are good, by running a variety of Java applications inside of Docker containers. AdoptOpenJDK/openjdk-tests/Issue #172 lists the applications that we have initially targeted to best exercise the AdoptOpenJDK binaries. For each application, we choose to run a selection of their functional tests.
Jacoco test material is pulled from the Jacoco repository.

To run any AQA tests locally, you follow the same pattern:

Ensure your test machine is set up with [test prereqs](https://github.com/AdoptOpenJDK/openjdk-tests/blob/master/doc/Prerequisites.md). For external tests, you do need Docker installed.

1. Download/unpack the SDK that you want to test to your test machine

2. export TEST_JDK_HOME=</pathToWhereYouInstalledSDK>

3. git clone https://github.com/AdoptOpenJDK/openjdk-tests.git

4. cd openjdk-tests

5. ./get.sh

6. cd TKG

7. export required environment variables, BUILD_LIST and EXTRA_DOCKER_ARGS (<export BUILD_LIST=external/jacoco> and <export EXTRA_DOCKER_ARGS="-v $TEST_JDK_HOME:/opt/java/openjdk">)

8. <make compile> (This fetches test material and compiles it, based on build.xml files in the test directories)

9.<make _jacoco_test> (When you defined BUILD_LIST to point to a directory in openjdk-tests/external, then this is a testCaseName from the playlist.xml file within the directory you chose)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also add following part as the last section:

When running these from the command-line, these tests are grouped under a make target called 'external', so 'make external' would run the entire set of tests found in the openjdk-tests/external directory. This is unadvisable! Limit what you compile and run, BUILD_LIST=external/<someSubDirectory>, and TARGET=<testCaseNameFromSubdirPlaylist>

These tests run regularly and results can be found in TRSS Third Party Application view.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also please update the layout. See the example https://github.com/AdoptOpenJDK/openjdk-tests/pull/2473/files

51 changes: 0 additions & 51 deletions external/jacoco/dockerfile/Dockerfile
View file
Open in desktop

This file was deleted.

13 changes: 13 additions & 0 deletions external/jacoco/test.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
github_url="https://github.com/jacoco/jacoco.git"
script="jacoco-test.sh"
test_results="testResults"
tag_version="master"
environment_variable="MODE=\"java\""
debian_packages="git maven"
debianslim_packages="${debian_packages}"
ubuntu_packages="${debian_packages}"
alpine_packages="git maven"
centos_packages="git maven"
clefos_packages="${centos_packages}"
ubi_packages="git maven"
ubi_minimal_packages="${ubi_packages}"