Update README.md #26
Update README.md #26
Conversation
| .currency("EUR") | ||
| .value(9998L); | ||
| paymentRequest.setAmount(amount); | ||
| paymentRequest.setAmount(body.getAmount()); |
There was a problem hiding this comment.
Best practice: the amount should not be retrieved from the frontend
In a 'real'-world integration, the amount should be fetched from a storage (db), and then shown on the frontend. The dependency is flipped
There was a problem hiding this comment.
Thats a fair point. Let's stick to your way.
| ``` | ||
|
|
||
| </details> | ||
| **Best practices:** The Adyen API supports idempotent requests, allowing you to retry a request multiple times while only performing the action once. This helps avoid unwanted duplication in case of failures and retries (e.g., you don't want to charge a shopper twice because they've hit the pay button two times, right?). To learn more about idempotency for payment requests, see [documentation](https://docs.adyen.com/development-resources/api-idempotency/). |
There was a problem hiding this comment.
We've added this as folks mentioned that it's unclear from a SDK-perspective how to pass this key. I'm okay with removing it and referencing the documentation instead
There was a problem hiding this comment.
I dont think we should remove the idempotency paragraph. We should keep the text and refer to the docs.
I just think it shouldn't be a step, especially as we do a suboptimal implementation. It would teach them a bad practice, right?
There was a problem hiding this comment.
That makes sense, should we then keep the code snippet?
| onAdditionalDetails: async (state, component, actions)=> { | ||
| const response = await sendPostRequest("/api/payments/details", state.data); | ||
| handleResponse(response, component); | ||
| // Uncomment this if you want to add Native 3DS |
There was a problem hiding this comment.
FYI: I need to make some changes to this function -> We need to accept/reject as follows: https://github.com/adyen-examples/adyen-java-spring-online-payments/blob/main/checkout-example-advanced/src/main/resources/static/dropin.js#L66-L87
We no longer need to check the response.action part
|
@BjornvdLaan I've added some of the README changes here: #24, could you have a look? I'll merge it into main afterwards |
Overview of changes:
amount.