Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

79 Keyboard scrolling support #91

Merged
merged 2 commits into from
Feb 10, 2025
Merged

79 Keyboard scrolling support #91

merged 2 commits into from
Feb 10, 2025

Conversation

ae9is
Copy link
Owner

@ae9is ae9is commented Feb 10, 2025

Fixes #79

The wrong element was being used to calculate the position of the font within the popout scroll. (The font preview element was being used rather than the font picker option.)

Example structure:

<div class="fontpicker" data-testid="default-fontpicker">
  <div class="fontpicker__preview font-preview-almarai"></div>
  <input class="fontpicker__search" type="text" value="">
  <div tabindex="-1" class="fontpicker__popout" role="listbox">
    <div class="fontpicker__option" role="option">
      <div class="font-preview-42dot_sans"></div>
    </div>
    <div class="fontpicker__option" role="option">
      <div class="font-preview-abeezee"></div>
    </div>
    <div class="fontpicker__option" role="option">
      <div class="font-preview-abel"></div>
    </div>
...

@ae9is ae9is linked an issue Feb 10, 2025 that may be closed by this pull request
@ae9is ae9is merged commit e5173bf into main Feb 10, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Keyboard scrolling support
1 participant