Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

79 Keyboard scrolling support #91

Merged
merged 2 commits into from
Feb 10, 2025
Merged

79 Keyboard scrolling support #91

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ec65f84
ide: add debug configuration
ae9is Feb 10, 2025
5fa7601
fix: keyboard arrow scrolling for fontpicker
ae9is Feb 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions .vscode/launch.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
{
// Use IntelliSense to learn about possible attributes.
// Hover to view descriptions of existing attributes.
// For more information, visit: https://go.microsoft.com/fwlink/?linkid=830387
"version": "0.2.0",
"configurations": [
{
"type": "chrome",
"request": "launch",
"name": "Launch Chrome against localhost",
"url": "http://localhost:3000",
"webRoot": "${workspaceFolder}/packages/fontpicker/src",
"sourceMapPathOverrides": {
"webpack:///./packages/fontpicker/src/*": "${workspaceFolder}/packages/fontpicker/src/*"
}
}
]
}
11 changes: 6 additions & 5 deletions packages/fontpicker/src/components/FontPicker.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -384,15 +384,16 @@ export default function FontPicker({
// selectedFont should be undefined IFF fontCategories is changed and the currently
// selectedFont is not in the new category.
if (selectedFont) {
const fontElement = popout.querySelector('.font-preview-' + selectedFont.sane) as HTMLElement
if (fontElement && fontElement instanceof HTMLElement) {
const fontTop = fontElement.offsetTop
const fontBottom = fontTop + fontElement.offsetHeight
const fontPreviewElement = popout.querySelector('.font-preview-' + selectedFont.sane) as HTMLElement
const fontOptionElement = fontPreviewElement?.parentElement
if (fontOptionElement && fontOptionElement instanceof HTMLElement) {
const fontTop = fontOptionElement.offsetTop
const fontBottom = fontTop + fontOptionElement.offsetHeight
const popTop = popout.scrollTop
const popBottom = popTop + popout.clientHeight
if (why === 'opening' || fontTop <= popTop) {
popout.scrollTop = fontTop
fontElement.parentElement?.classList.add('selected')
fontOptionElement.classList.add('selected')
const optionRef = getOptionsRef()?.get(selectedFont.sane)
optionRef?.classList.add('selected')
} else if (fontBottom >= popBottom) {
Expand Down