-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Documentation: Guide update: Updates to "Basic Scene" Guide #5213
Conversation
Moved from examples\showcase to examples\docs. |
Following up on this PR & also #5211 I believe both can be merged. Unresolved issues that came up in review were: auto-sync to glitch. Technically complicated. #5222 tracks the options here: So on the basis that we merged #5124 and #5215 already, I think we should be OK to merge this one & #5211 |
Ugh. sorry. this fell through the cracks and is a good contribution. I'm all about removing glitches from the docs. If you can rebase I'll merge! Thanks so much |
1st example shows environment component (initial part of tutorial) 2nd example shows custom environment (optional part of tutorial)
Since only the "custom environment" bit is marked as "optional" in the docs.
Rebased. I also reworked this a bit to deal with the "optional" part of the tutorial, so now we have 2 examples, one with the pre-canned environment, and one with the custom environment. |
Thanks so much for jumping back on it so quickly |
Description:
2nd of what will in fact be 4 updates to bring external glicth examples up-to-date & into the A-Frame repo, per #5207.