Documentation: Guide update: Minecraft demo #5215
Conversation
Interim steps avoid need to refer out to codepens.
| <meta charset="utf-8"> | ||
| <title>Aincraft</title> | ||
| <meta name="description" content="Aincraft"> | ||
| <script src="https://aframe.io/releases/1.4.0/aframe.min.js"></script> |
There was a problem hiding this comment.
link to master build instead of hard coded version like other examples
There was a problem hiding this comment.
Can do. Reason I did it this way was so that the HTML could easily be copy/pasted to another context (e.g. Glitch) and still work.
A small helping hand for beginners who might want to play with the example code, without cloning the A-Frame repo.
But if you prefer consistency with the other examples, that's - just wanted to share this consideration...
There was a problem hiding this comment.
I also commented on it in #5213 (comment)
| @@ -0,0 +1,36 @@ | |||
| /* global AFRAME */ | |||
There was a problem hiding this comment.
showcase directory of the examples should illustrate concrete use cases and be distinct. aincraft sounds a bit abstract and overlaps a bit with others. I feel these should go into a different directory. Perhaps:
examples/docs/...
There was a problem hiding this comment.
Moved to examples/docs and created a new section "Examples from Documentation" on the examples page.
Will do the same for other PRs, but it will make merging easier if we get this merged to master & then I update the other PRs.
| }, | ||
|
|
||
| update: function () { | ||
| const data = this.data; |
There was a problem hiding this comment.
Fixed. I will look into adding linting rule for this.
|
Hopefully this is ready to merge now. I prefer to get this one merged first, then I'll fix up the others to move examples from showcase folder to docs folder. |
|
|
||
| <p data-height="265" data-theme-id="dark" data-slug-hash="OpbwMJ" data-default-tab="html,result" data-user="mozvr" data-embed-version="2" data-pen-title="Minecraft VR Demo (Final)" data-preview="true" data-editable="true" class="codepen">See the Pen <a href="http://codepen.io/mozvr/pen/OpbwMJ/">Minecraft VR Demo (Final)</a> by mozvr (<a href="http://codepen.io/mozvr">@mozvr</a>) on <a href="http://codepen.io">CodePen</a>.</p> | ||
| [webxr]: https://immersiveweb.dev/ | ||
|
|
||
| [demorecorded]: https://supermedium.com/superframe/scenes/aincraft/?avatar-recording=recording.json |
|
Thanks for the patience |
* Copy example from glitch * Update example to use latest working code * Add link to Community Components example * Consistently use jsdelivr for CDN * Update Title * Update documentation of community components example * Fix docs lint error * Add comment explaining what to do if copy/pasting code. * Tidy up. * Move community components from "showcase" to "docs" * Fix some bad links left over from #5215 * Use versioned release here Docs will be auto-updated using per-release process.
Description:
4th of 4 updates to bring external glitch examples up-to-date & into the A-Frame repo, per #5207.
This one addresses the Minecraft Demo
Bring code from Glitch into A-Frame Examples
Code up-to-date with latest versions
Code and documentation match
Refernces to WebVR -> WebXR