Destination redshift: convert test classes to kotlin #38893
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
edgao
force-pushed
the
edgao/redshift_test_kotlin_conversion
branch
from
2af3bd1 to
2489015
Compare
edgao
force-pushed
the
edgao/redshift_no_more_standard_inserts
branch
from
f871777 to
4fddc2c
Compare
edgao
force-pushed
the
edgao/redshift_test_kotlin_conversion
branch
from
2489015 to
7c1a4ed
Compare
edgao
force-pushed
the
edgao/redshift_no_more_standard_inserts
branch
from
4fddc2c to
21f196b
Compare
edgao
force-pushed
the
edgao/redshift_test_kotlin_conversion
branch
from
7c1a4ed to
f345c43
Compare
edgao
force-pushed
the
edgao/redshift_no_more_standard_inserts
branch
from
21f196b to
de741dc
Compare
edgao
force-pushed
the
edgao/redshift_test_kotlin_conversion
branch
from
f345c43 to
2864bef
Compare
edgao
force-pushed
the
edgao/redshift_no_more_standard_inserts
branch
from
de741dc to
3882716
Compare
edgao
force-pushed
the
edgao/redshift_test_kotlin_conversion
branch
from
2864bef to
d0495a9
Compare
This was referenced Jun 5, 2024
edgao
force-pushed
the
edgao/redshift_test_kotlin_conversion
branch
from
d0495a9 to
91123ed
Compare
edgao
commented
Jun 7, 2024
...irbyte/integrations/destination/redshift/RedshiftS3StagingInsertDestinationAcceptanceTest.kt
Outdated
Show resolved
Hide resolved
edgao
force-pushed
the
edgao/redshift_no_more_standard_inserts
branch
from
3882716 to
a31cc6c
Compare
edgao
force-pushed
the
edgao/redshift_test_kotlin_conversion
branch
from
91123ed to
769fb16
Compare
edgao
force-pushed
the
edgao/redshift_no_more_standard_inserts
branch
from
a31cc6c to
3b48c99
Compare
edgao
force-pushed
the
edgao/redshift_test_kotlin_conversion
branch
2 times, most recently
from
4c815f2 to
6486614
Compare
edgao
force-pushed
the
edgao/redshift_no_more_standard_inserts
branch
from
3b48c99 to
ae12995
Compare
edgao
force-pushed
the
edgao/redshift_test_kotlin_conversion
branch
from
6486614 to
52effe1
Compare
edgao
force-pushed
the
edgao/redshift_no_more_standard_inserts
branch
from
ae12995 to
ff5f8a5
Compare
edgao
force-pushed
the
edgao/redshift_test_kotlin_conversion
branch
3 times, most recently
from
7b7e9d4 to
c7bc16b
Compare
edgao
force-pushed
the
edgao/redshift_no_more_standard_inserts
branch
from
ff5f8a5 to
0be1c21
Compare
edgao
force-pushed
the
edgao/redshift_test_kotlin_conversion
branch
2 times, most recently
from
b89aa67 to
32e6e66
Compare
edgao
force-pushed
the
edgao/redshift_no_more_standard_inserts
branch
from
0be1c21 to
007829b
Compare
edgao
force-pushed
the
edgao/redshift_test_kotlin_conversion
branch
from
32e6e66 to
c783a09
Compare
edgao
force-pushed
the
edgao/redshift_no_more_standard_inserts
branch
from
007829b to
a6564b8
Compare
edgao
force-pushed
the
edgao/redshift_test_kotlin_conversion
branch
from
c783a09 to
6776c9c
Compare
edgao
force-pushed
the
edgao/redshift_no_more_standard_inserts
branch
from
a6564b8 to
e4e8169
Compare
edgao
force-pushed
the
edgao/redshift_test_kotlin_conversion
branch
from
6776c9c to
a4c065e
Compare
Base automatically changed from
edgao/redshift_no_more_standard_inserts
to
master
June 18, 2024 19:57
edgao
force-pushed
the
edgao/redshift_test_kotlin_conversion
branch
4 times, most recently
from
5ab2266 to
8e2fa50
Compare
edgao
force-pushed
the
edgao/redshift_test_kotlin_conversion
branch
from
8e2fa50 to
326d11e
Compare
stephane-airbyte
approved these changes
Jun 26, 2024
This was referenced Jun 26, 2024
xiaohansong
pushed a commit
that referenced
this pull request
Jul 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes https://github.com/airbytehq/airbyte-internal-issues/issues/8360
not strictly necessary, I just don't want to deal with kotlin/java interop nonsense
the next PR in the stack actually deletes all the
*DestinationAcceptanceTestclasses, so feel free to ignore them. Please do skim the files in thetyping_dedupingpackage, as well asRedshiftConnectionTestthough, along with the unit tests.