wip #50434
wip #50434
Conversation
This reverts commit 90aa35e.
Co-authored-by: Jonathan Pearlin <[email protected]>
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
octavia-squidington-iii
added
area/connectors
Co-authored-by: Jonathan Pearlin <[email protected]>
| } | ||
| } else { | ||
| try { | ||
| when (value) { |
There was a problem hiding this comment.
It may make this cleaner to encapsulate this logic in an extension function on the value -- something like value.setStatementValue(statement=statement). The extension function would encapsulate this when block, making this code easier to test separate from the type conversion expectations.
| .filter { field -> field.name !in airbyteFields } | ||
| .map { field -> | ||
| try { | ||
| when (field.type.type) { |
There was a problem hiding this comment.
Same comment as above...this feels like another good use of an extension function on the type to encapsulate this conversion logic and make it easier to test.
| private val dataSourceFactory: MSSQLDataSourceFactory | ||
| ) : DestinationWriter { | ||
| override fun createStreamLoader(stream: DestinationStream): StreamLoader { | ||
| val dataSource = dataSourceFactory.getDataSource(config) |
There was a problem hiding this comment.
We may want to do this in the constructor/init/post construct method. Otherwise, we are creating a data source per stream, which means d x s connections instead of just d connections if the data source is shared between streams (preferred to limit connections).
| } | ||
| } | ||
| } catch (ex: Exception) { | ||
| KotlinLogging.logger {}.error(ex) { ex.message } |
There was a problem hiding this comment.
This should probably be a file level variable to avoid creating the logger each time that the code catches.
...2/src/test-integration/kotlin/io/airbyte/integrations/destination/mssql/v2/MSSQLCheckTest.kt
Outdated
Show resolved
Hide resolved
This reverts commit 90aa35e.
Co-authored-by: Jonathan Pearlin <[email protected]>
Co-authored-by: Jonathan Pearlin <[email protected]>
jdpgrailsdev
force-pushed
the
move/destination-mssql-v2
branch
from
140aeda to
57bcf83
Compare
jdpgrailsdev
force-pushed
the
move/destination-mssql-v2
branch
from
57bcf83 to
bc730ce
Compare
What
How
Review guide
User Impact
Can this PR be safely reverted and rolled back?