wip #50434
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| services: | ||
| sql-server: | ||
| image: mcr.microsoft.com/mssql/server:2022-latest | ||
| ports: | ||
| - "1433:1433" | ||
| environment: | ||
| - ACCEPT_EULA=Y | ||
| - MSSQL_SA_PASSWORD=Averycomplicatedpassword1! |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,28 @@ | ||
| package io.airbyte.integrations.destination.mssql.v2 | ||
|
|
||
| import io.airbyte.cdk.load.check.DestinationChecker | ||
| import io.airbyte.integrations.destination.mssql.v2.config.MSSQLConfiguration | ||
| import io.airbyte.integrations.destination.mssql.v2.config.MSSQLDataSourceFactory | ||
| import jakarta.inject.Singleton | ||
| import java.util.UUID | ||
| import javax.sql.DataSource | ||
|
|
||
| @Singleton | ||
| class MSSQLChecker(private val dataSourceFactory: MSSQLDataSourceFactory) : | ||
| DestinationChecker<MSSQLConfiguration> { | ||
| override fun check(config: MSSQLConfiguration) { | ||
| val dataSource: DataSource = dataSourceFactory.getDataSource(config) | ||
| val testTableName = "check_test_${UUID.randomUUID()}" | ||
| val fullyQualifiedTableName = "[${config.rawDataSchema}].[${testTableName}]" | ||
| dataSource.connection.use { connection -> | ||
| connection.createStatement().use { statement -> | ||
| statement.executeUpdate( | ||
| """ | ||
| CREATE TABLE ${fullyQualifiedTableName} (test int); | ||
| DROP TABLE ${fullyQualifiedTableName}; | ||
| """.trimIndent(), | ||
| ) | ||
| } | ||
| } | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,329 @@ | ||
| package io.airbyte.integrations.destination.mssql.v2 | ||
|
|
||
| import io.airbyte.cdk.load.command.DestinationStream | ||
| import io.airbyte.cdk.load.data.AirbyteType | ||
| import io.airbyte.cdk.load.data.AirbyteValue | ||
| import io.airbyte.cdk.load.data.ArrayType | ||
| import io.airbyte.cdk.load.data.ArrayTypeWithoutSchema | ||
| import io.airbyte.cdk.load.data.ArrayValue | ||
| import io.airbyte.cdk.load.data.BooleanType | ||
| import io.airbyte.cdk.load.data.BooleanValue | ||
| import io.airbyte.cdk.load.data.DateType | ||
| import io.airbyte.cdk.load.data.DateValue | ||
| import io.airbyte.cdk.load.data.FieldType | ||
| import io.airbyte.cdk.load.data.IntegerType | ||
| import io.airbyte.cdk.load.data.IntegerValue | ||
| import io.airbyte.cdk.load.data.NullValue | ||
| import io.airbyte.cdk.load.data.NumberType | ||
| import io.airbyte.cdk.load.data.NumberValue | ||
| import io.airbyte.cdk.load.data.ObjectType | ||
| import io.airbyte.cdk.load.data.ObjectTypeWithEmptySchema | ||
| import io.airbyte.cdk.load.data.ObjectTypeWithoutSchema | ||
| import io.airbyte.cdk.load.data.ObjectValue | ||
| import io.airbyte.cdk.load.data.StringType | ||
| import io.airbyte.cdk.load.data.StringValue | ||
| import io.airbyte.cdk.load.data.TimeTypeWithTimezone | ||
| import io.airbyte.cdk.load.data.TimeTypeWithoutTimezone | ||
| import io.airbyte.cdk.load.data.TimeValue | ||
| import io.airbyte.cdk.load.data.TimestampTypeWithTimezone | ||
| import io.airbyte.cdk.load.data.TimestampTypeWithoutTimezone | ||
| import io.airbyte.cdk.load.data.TimestampValue | ||
| import io.airbyte.cdk.load.data.UnionType | ||
| import io.airbyte.cdk.load.data.UnknownType | ||
| import io.airbyte.cdk.load.data.UnknownValue | ||
| import io.airbyte.cdk.load.message.DestinationRecord | ||
| import io.airbyte.cdk.load.util.TimeStringUtility.toLocalDate | ||
| import io.airbyte.cdk.load.util.TimeStringUtility.toLocalDateTime | ||
| import io.airbyte.cdk.load.util.TimeStringUtility.toOffset | ||
| import io.airbyte.integrations.destination.mssql.v2.config.MSSQLConfiguration | ||
| import io.airbyte.integrations.destination.mssql.v2.convert.AirbyteTypeToSqlType | ||
| import io.airbyte.integrations.destination.mssql.v2.convert.SqlTypeToMssqlType | ||
| import io.airbyte.protocol.models.AirbyteRecordMessageMeta | ||
| import io.airbyte.protocol.models.AirbyteRecordMessageMetaChange | ||
| import io.airbyte.protocol.models.Jsons | ||
| import java.sql.Date | ||
| import java.sql.PreparedStatement | ||
| import java.sql.ResultSet | ||
| import java.sql.Time | ||
| import java.sql.Timestamp | ||
| import java.sql.Types | ||
| import java.time.Instant | ||
| import java.time.format.DateTimeParseException | ||
| import java.util.UUID | ||
|
|
||
| class MSSQLQueryBuilder( | ||
| config: MSSQLConfiguration, | ||
| private val stream: DestinationStream, | ||
| ) { | ||
|
|
||
| companion object { | ||
| val AIRBYTE_RAW_ID = "_airbyte_raw_id" | ||
| val AIRBYTE_EXTRACTED_AT = "_airbyte_extracted_at" | ||
| val AIRBYTE_META = "_airbyte_meta" | ||
| val AIRBYTE_GENERATION_ID = "_airbyte_generation_id" | ||
|
|
||
| val airbyteFinalTableFields = | ||
| listOf( | ||
| NamedField(AIRBYTE_RAW_ID, FieldType(StringType, false)), | ||
| NamedField(AIRBYTE_EXTRACTED_AT, FieldType(TimestampTypeWithoutTimezone, false)), | ||
| NamedField(AIRBYTE_META, FieldType(ObjectTypeWithoutSchema, false)), | ||
| NamedField(AIRBYTE_GENERATION_ID, FieldType(IntegerType, false)), | ||
| ) | ||
|
|
||
| val airbyteFields = airbyteFinalTableFields.map { it.name }.toSet() | ||
|
|
||
| inline fun <reified T> deserialize(value: String): T = | ||
| Jsons.deserialize(value, T::class.java) | ||
| } | ||
|
|
||
| data class NamedField(val name: String, val type: FieldType) | ||
| data class NamedValue(val name: String, val value: AirbyteValue) | ||
|
|
||
| private val internalSchema: String = config.rawDataSchema | ||
| private val outputSchema: String = stream.descriptor.namespace ?: config.schema | ||
| private val tableName: String = stream.descriptor.name | ||
| private val fqTableName = "$outputSchema.$tableName" | ||
|
|
||
| val finalTableSchema: List<NamedField> = | ||
| airbyteFinalTableFields + extractFinalTableSchema(stream.schema) | ||
|
|
||
| fun createFinalTableIfNotExists(): String = | ||
| createTableIfNotExists(fqTableName, finalTableSchema) | ||
|
|
||
| fun createFinalSchemaIfNotExists(): String = createSchemaIfNotExists(outputSchema) | ||
|
|
||
| fun getFinalTableInsertColumnHeader(): String = | ||
| getFinalTableInsertColumnHeader(fqTableName, finalTableSchema) | ||
|
|
||
| fun populateStatement( | ||
| statement: PreparedStatement, | ||
| record: DestinationRecord, | ||
| schema: List<NamedField> | ||
| ) { | ||
| val toSqlType = AirbyteTypeToSqlType() | ||
| val recordObject = record.data as ObjectValue | ||
|
|
||
| var airbyteMetaStatementIndex: Int? = null | ||
| val airbyteMeta = | ||
| AirbyteRecordMessageMeta().apply { | ||
| changes = mutableListOf() | ||
| setAdditionalProperty("syncId", stream.syncId) | ||
| } | ||
| schema.forEachIndexed { index, field -> | ||
| val stmntIdx = index + 1 | ||
| val value = recordObject.values[field.name] | ||
| val sqlType = toSqlType.convert(field.type.type) | ||
|
|
||
| if (value == null) { | ||
| if (field.name in airbyteFields) { | ||
| when (field.name) { | ||
| AIRBYTE_RAW_ID -> | ||
| statement.setString(stmntIdx, UUID.randomUUID().toString()) | ||
| AIRBYTE_EXTRACTED_AT -> | ||
| statement.setTimestamp( | ||
| stmntIdx, | ||
| Timestamp.from(Instant.ofEpochMilli(record.emittedAtMs)) | ||
| ) | ||
| AIRBYTE_GENERATION_ID -> statement.setLong(stmntIdx, stream.generationId) | ||
| AIRBYTE_META -> airbyteMetaStatementIndex = stmntIdx | ||
| } | ||
| } else { | ||
| statement.setNull(stmntIdx, sqlType) | ||
| } | ||
| } else { | ||
| try { | ||
| when (value) { | ||
| is ObjectValue -> | ||
| statement.setString(stmntIdx, Jsons.serialize(value.values)) | ||
| is ArrayValue -> | ||
| statement.setString(stmntIdx, Jsons.serialize(value.values)) | ||
| is BooleanValue -> statement.setBoolean(stmntIdx, value.value) | ||
| is DateValue -> | ||
| statement.setDate(stmntIdx, Date.valueOf(toLocalDate((value.value)))) | ||
| is IntegerValue -> statement.setLong(stmntIdx, value.value.toLong()) | ||
| NullValue -> statement.setNull(stmntIdx, sqlType) | ||
| is NumberValue -> statement.setDouble(stmntIdx, value.value.toDouble()) | ||
| is StringValue -> | ||
| if (sqlType == Types.VARCHAR || sqlType == Types.LONGVARCHAR) { | ||
| statement.setString(stmntIdx, value.value) | ||
| } else { | ||
| throw IllegalArgumentException() | ||
| } | ||
| is TimeValue -> | ||
| statement.setTime(stmntIdx, Time.valueOf(toOffset(value.value))) | ||
| is TimestampValue -> | ||
| statement.setTimestamp( | ||
| stmntIdx, | ||
| Timestamp.valueOf(toLocalDateTime(value.value)) | ||
| ) | ||
| is UnknownValue -> | ||
| statement.setString(stmntIdx, Jsons.serialize(value.value)) | ||
| } | ||
| } catch (e: DateTimeParseException) { | ||
| statement.setNull(stmntIdx, sqlType) | ||
| airbyteMeta.changes.add( | ||
| AirbyteRecordMessageMetaChange() | ||
| .withField(field.name) | ||
| .withChange(AirbyteRecordMessageMetaChange.Change.NULLED) | ||
| .withReason( | ||
| AirbyteRecordMessageMetaChange.Reason | ||
| .DESTINATION_SERIALIZATION_ERROR | ||
| ) | ||
| ) | ||
| } catch (e: IllegalArgumentException) { | ||
| statement.setNull(stmntIdx, sqlType) | ||
| airbyteMeta.changes.add( | ||
| AirbyteRecordMessageMetaChange() | ||
| .withField(field.name) | ||
| .withChange(AirbyteRecordMessageMetaChange.Change.NULLED) | ||
| .withReason( | ||
| AirbyteRecordMessageMetaChange.Reason | ||
| .DESTINATION_SERIALIZATION_ERROR | ||
| ) | ||
| ) | ||
| } | ||
| // when (sqlType) { | ||
| // Types.LONGVARCHAR -> statement.setString(statementIndex, | ||
| // Jsons.serialize(value)) | ||
| // Types.BOOLEAN -> statement.setBoolean(statementIndex, value as | ||
| // Boolean) | ||
| // Types.DATE -> statement.setDate(statementIndex, value as Date) | ||
| // Types.BIGINT -> | ||
| // statement.setLong(statementIndex, (value as | ||
| // BigInteger).toLong()) | ||
| // Types.DECIMAL -> | ||
| // statement.setDouble(statementIndex, (value as | ||
| // BigDecimal).toDouble()) | ||
| // Types.VARCHAR -> statement.setString(statementIndex, value as | ||
| // String) | ||
| // Types.TIMESTAMP_WITH_TIMEZONE -> | ||
| // statement.setTimestamp(statementIndex, value as Timestamp) | ||
| // Types.TIME -> statement.setTime(statementIndex, value as Time) | ||
| // Types.TIMESTAMP -> statement.setTimestamp(statementIndex, | ||
| // value as Timestamp) | ||
| // } | ||
| } | ||
| } | ||
| airbyteMetaStatementIndex?.let { statementIndex -> | ||
| statement.setString(statementIndex, Jsons.serialize(airbyteMeta)) | ||
| } | ||
| } | ||
|
|
||
| fun readResult(rs: ResultSet, schema: List<NamedField>): ObjectValue { | ||
| val valueMap = | ||
| schema | ||
| .filter { field -> field.name !in airbyteFields } | ||
| .map { field -> | ||
| try { | ||
| when (field.type.type) { | ||
|
There was a problem hiding this comment. Same comment as above...this feels like another good use of an extension function on the type to encapsulate this conversion logic and make it easier to test. |
||
| is StringType -> | ||
| NamedValue(field.name, StringValue(rs.getString(field.name))) | ||
| is ArrayType -> TODO() | ||
| ArrayTypeWithoutSchema -> TODO() | ||
| BooleanType -> | ||
| NamedValue(field.name, BooleanValue(rs.getBoolean(field.name))) | ||
| DateType -> | ||
| NamedValue(field.name, DateValue(rs.getDate(field.name).toString())) | ||
| IntegerType -> | ||
| NamedValue(field.name, IntegerValue(rs.getLong(field.name))) | ||
| NumberType -> | ||
| NamedValue( | ||
| field.name, | ||
| NumberValue(rs.getDouble(field.name).toBigDecimal()) | ||
| ) | ||
| is ObjectType -> | ||
| NamedValue( | ||
| field.name, | ||
| ObjectValue.from( | ||
| deserialize<Map<String, Any?>>(rs.getString(field.name)) | ||
| ) | ||
| ) | ||
| ObjectTypeWithEmptySchema -> | ||
| NamedValue( | ||
| field.name, | ||
| ObjectValue.from( | ||
| deserialize<Map<String, Any?>>(rs.getString(field.name)) | ||
| ) | ||
| ) | ||
| ObjectTypeWithoutSchema -> | ||
| NamedValue( | ||
| field.name, | ||
| ObjectValue.from( | ||
| deserialize<Map<String, Any?>>(rs.getString(field.name)) | ||
| ) | ||
| ) | ||
| TimeTypeWithTimezone -> | ||
| NamedValue(field.name, TimeValue(rs.getString(field.name))) | ||
| TimeTypeWithoutTimezone -> | ||
| NamedValue(field.name, TimeValue(rs.getString(field.name))) | ||
| TimestampTypeWithTimezone -> | ||
| NamedValue(field.name, TimestampValue(rs.getString(field.name))) | ||
| TimestampTypeWithoutTimezone -> | ||
| NamedValue(field.name, TimestampValue(rs.getString(field.name))) | ||
| is UnionType -> TODO() | ||
| is UnknownType -> TODO() | ||
| } | ||
| } catch (e: NullPointerException) { | ||
| null | ||
| } | ||
| } | ||
| .filterNotNull() | ||
| .associate { it.name to it.value } | ||
| return ObjectValue.from(valueMap) | ||
| } | ||
|
|
||
| fun selectAllRecords(): String = "SELECT * FROM $fqTableName" | ||
|
|
||
| private fun createSchemaIfNotExists(schema: String): String = | ||
| """ | ||
| IF NOT EXISTS (SELECT name FROM sys.schemas WHERE name = '$schema') | ||
| BEGIN | ||
| EXEC ('CREATE SCHEMA $schema'); | ||
| END | ||
| """.trimIndent() | ||
|
|
||
| private fun createTableIfNotExists(fqTableName: String, schema: List<NamedField>): String = | ||
| """ | ||
| IF OBJECT_ID('$fqTableName') IS NULL | ||
| BEGIN | ||
| CREATE TABLE $fqTableName | ||
| ( | ||
| ${airbyteTypeToSqlSchema(schema, separator = ",\n ")} | ||
| ); | ||
| END | ||
| """.trimIndent() | ||
|
|
||
| private fun getFinalTableInsertColumnHeader( | ||
| fqTableName: String, | ||
| schema: List<NamedField> | ||
| ): String { | ||
| return StringBuilder() | ||
| .apply { | ||
| append("INSERT INTO $fqTableName(") | ||
| append(schema.map { it.name }.joinToString(", ")) | ||
| append(") VALUES (") | ||
| append(schema.map { "?" }.joinToString(", ")) | ||
| append(")") | ||
| } | ||
| .toString() | ||
| } | ||
|
|
||
| private fun extractFinalTableSchema(schema: AirbyteType): List<NamedField> = | ||
| when (schema) { | ||
| is ObjectType -> { | ||
| (stream.schema as ObjectType) | ||
| .properties | ||
| .map { NamedField(name = it.key, type = it.value) } | ||
| .toList() | ||
| } | ||
| else -> TODO("most likely fail hard") | ||
| } | ||
|
|
||
| private fun airbyteTypeToSqlSchema(schema: List<NamedField>, separator: String): String { | ||
| val toSqlType = AirbyteTypeToSqlType() | ||
| val toMssqlType = SqlTypeToMssqlType() | ||
| return schema | ||
| .map { "${it.name} ${toMssqlType.convert(toSqlType.convert(it.type.type)).sqlString}" } | ||
| .joinToString(separator = separator) | ||
| } | ||
| } | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It may make this cleaner to encapsulate this logic in an extension function on the value -- something like
value.setStatementValue(statement=statement). The extension function would encapsulate this when block, making this code easier to test separate from the type conversion expectations.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated