only run integration tests for a subset of integrations during PR builds #710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Base automatically changed from
cgardens/remove_salesforce_integration_tests_from_ci
to
master
October 26, 2020 21:27
cgardens
force-pushed
the
cgardens/selective_service
branch
from
f365762 to
d687ce6
Compare
jrhizor
suggested changes
Oct 26, 2020
tools/bin/integration_test_pr.sh
Outdated
| :airbyte-integrations:connectors:destination-csv:integrationTest \ | ||
| :airbyte-integrations:connectors:source-postgres-singer:integrationTest \ | ||
| :airbyte-integrations:connectors:source-stripe-singer:integrationTest \ | ||
| :airbyte-integrations:connectors:source-exchangeratesapi-singer:integrationTest |
There was a problem hiding this comment.
nit: missing newline at end of file
tools/bin/standard_test_pr.sh
Outdated
| assert_root | ||
|
|
||
| ./gradlew --no-daemon --scan -x generateProtocolClassFiles \ | ||
| :airbyte-integrations:connectors:source-github-singer:standardSourceTest |
There was a problem hiding this comment.
nit: missing newline at end of file
.github/workflows/gradle.yml
Outdated
| run: ./gradlew --no-daemon integrationTest --scan -x generateProtocolClassFiles | ||
|
|
||
| - name: Run Standard Source Tests | ||
| - name: Run Standard Source Tests (PR) | ||
| if: success() && github.ref == 'refs/heads/master' |
There was a problem hiding this comment.
is the matching condition reversed?
.github/workflows/gradle.yml
Outdated
| run: ./tools/bin/standard_test_pr.sh | ||
|
|
||
| - name: Run Standard Source Tests (Master) | ||
| if: success() && github.ref != 'refs/heads/master' |
|
@jrhizor - nice catch. in fixing one those conditions being flipped, i managed to mess up the other. should be all good now. |
jrhizor
approved these changes
Oct 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What