Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

only run integration tests for a subset of integrations during PR builds #710

Merged
merged 4 commits into from
Oct 27, 2020
Merged
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions .github/workflows/gradle.yml
Original file line number Diff line number Diff line change
Expand Up @@ -54,10 +54,20 @@ jobs:
- name: Ensure no file change
run: git status --porcelain && test -z "$(git status --porcelain)"

- name: Run Integration Tests
- name: Run Integration Tests (PR)
if: success() && github.ref != 'refs/heads/master'
run: ./tools/bin/integration_test_pr.sh

- name: Run Integration Tests (Master)
if: success() && github.ref == 'refs/heads/master'
run: ./gradlew --no-daemon integrationTest --scan -x generateProtocolClassFiles

- name: Run Standard Source Tests
- name: Run Standard Source Tests (PR)
if: success() && github.ref == 'refs/heads/master'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is the matching condition reversed?

run: ./tools/bin/standard_test_pr.sh

- name: Run Standard Source Tests (Master)
if: success() && github.ref != 'refs/heads/master'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also here

run: ./gradlew --no-daemon standardSourceTest --scan

- name: Build Core Docker Images
Expand Down
15 changes: 15 additions & 0 deletions tools/bin/integration_test_pr.sh
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
#!/usr/bin/env bash

set -e

. tools/lib/lib.sh

assert_root

./gradlew --no-daemon --scan -x generateProtocolClassFiles \
:airbyte-integrations:connectors:destination-bigquery:integrationTest \
:airbyte-integrations:connectors:destination-postgres:integrationTest \
:airbyte-integrations:connectors:destination-csv:integrationTest \
:airbyte-integrations:connectors:source-postgres-singer:integrationTest \
:airbyte-integrations:connectors:source-stripe-singer:integrationTest \
:airbyte-integrations:connectors:source-exchangeratesapi-singer:integrationTest
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: missing newline at end of file

10 changes: 10 additions & 0 deletions tools/bin/standard_test_pr.sh
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
#!/usr/bin/env bash

set -e

. tools/lib/lib.sh

assert_root

./gradlew --no-daemon --scan -x generateProtocolClassFiles \
:airbyte-integrations:connectors:source-github-singer:standardSourceTest
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: missing newline at end of file