address @hiddeco feedback

Signed-off-by: Kent Rancourt <[email protected]>

api/v1alpha1/promotion_types_test.go

@@ -23,13 +23,13 @@ func TestPromotionRetry_GetTimeout(t *testing.T) {
 			want:     ptr.To(time.Hour),
 		},
 		{
-			name:     "threshold is not set",
+			name:     "timeout is not set",
 			retry:    &PromotionStepRetry{},
 			fallback: ptr.To(time.Hour),
 			want:     ptr.To(time.Hour),
 		},
 		{
-			name: "threshold is set",
+			name: "timeout is set",
 			retry: &PromotionStepRetry{
 				Timeout: &metav1.Duration{
 					Duration: 3 * time.Hour,

internal/directives/simple_engine_promote.go

@@ -124,15 +124,16 @@ func (e *SimpleEngine) executeSteps(
 
 		if stepExecMeta.Status == kargoapi.PromotionPhaseSucceeded {
 			stepExecMeta.FinishedAt = ptr.To(metav1.Now())
-			stepExecMeta.ErrorCount = 0
 			if healthCheck := result.HealthCheckStep; healthCheck != nil {
 				healthChecks = append(healthChecks, *healthCheck)
 			}
 			continue // Move on to the next step
 		}
 
 		// Treat errors and logical failures the same for now.
-		// TODO(krancour): These may be handled differently in the future.
+		// TODO(krancour): In the future, we should fail without retry for logical
+		// failures and unrecoverable errors and retry only those errors with a
+		// chance of recovery.
 		if stepExecMeta.Status != kargoapi.PromotionPhaseRunning {
 			stepExecMeta.ErrorCount++
 			// Check if the error threshold has been met.