Skip to content

address @hiddeco feedback

Codecov / codecov/patch succeeded Dec 5, 2024 in 0s

76.08% of diff hit (target 51.10%)

View this Pull Request on Codecov

76.08% of diff hit (target 51.10%)

Annotations

Check warning on line 265 in api/v1alpha1/promotion_types.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

api/v1alpha1/promotion_types.go#L264-L265

Added lines #L264 - L265 were not covered by tests

Check warning on line 489 in internal/controller/promotions/promotions.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

internal/controller/promotions/promotions.go#L479-L489

Added lines #L479 - L489 were not covered by tests

Check warning on line 498 in internal/controller/promotions/promotions.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

internal/controller/promotions/promotions.go#L497-L498

Added lines #L497 - L498 were not covered by tests

Check warning on line 514 in internal/controller/promotions/promotions.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

internal/controller/promotions/promotions.go#L514

Added line #L514 was not covered by tests

Check warning on line 519 in internal/controller/promotions/promotions.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

internal/controller/promotions/promotions.go#L516-L519

Added lines #L516 - L519 were not covered by tests

Check warning on line 523 in internal/controller/promotions/promotions.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

internal/controller/promotions/promotions.go#L522-L523

Added lines #L522 - L523 were not covered by tests

Check warning on line 131 in internal/directives/argocd_updater.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

internal/directives/argocd_updater.go#L130-L131

Added lines #L130 - L131 were not covered by tests

Check warning on line 136 in internal/directives/argocd_updater.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

internal/directives/argocd_updater.go#L135-L136

Added lines #L135 - L136 were not covered by tests

Check warning on line 75 in internal/directives/simple_engine_promote.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

internal/directives/simple_engine_promote.go#L71-L75

Added lines #L71 - L75 were not covered by tests

Check warning on line 128 in internal/directives/simple_engine_promote.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

internal/directives/simple_engine_promote.go#L128

Added line #L128 was not covered by tests