Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Cleanup] Remove old, unused methods in gflownet.py #332

Merged
merged 2 commits into from
Jul 12, 2024
Merged

[Cleanup] Remove old, unused methods in gflownet.py #332

merged 2 commits into from
Jul 12, 2024

Conversation

alexhernandezgarcia
Copy link
Owner

@alexhernandezgarcia alexhernandezgarcia commented Jul 4, 2024 •
edited
Loading

Fairly simple: there were a couple of old methods hanging in gflownet.py that are not used any longer.

Update: deleting also a couple of methods in logger.py.

@alexhernandezgarcia alexhernandezgarcia requested review from AlexandraVolokhova and nikita-0209 and removed request for nikita-0209 July 4, 2024 18:44
alexhernandezgarcia
alexhernandezgarcia commented Jul 12, 2024
View reviewed changes
Copy link
Owner Author

@alexhernandezgarcia alexhernandezgarcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will merge, since it's been pending for a while and it should be harmless.

@alexhernandezgarcia alexhernandezgarcia merged commit e2de6db into main Jul 12, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexandraVolokhova AlexandraVolokhova Awaiting requested review from AlexandraVolokhova

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@alexhernandezgarcia