Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow archived forms to be made live #464

Merged
merged 1 commit into from
Mar 27, 2024
Merged

Allow archived forms to be made live #464

merged 1 commit into from
Mar 27, 2024

Conversation

DavidBiddle
Copy link
Contributor

What problem does this pull request solve?

Trello card: https://trello.com/c/li50etsD/1432-implement-form-unarchiving

Updates the state machine to allow archived and archived_with_draft forms to be made live. This will enable us to implement unarchiving a form in forms-admin.

Things to consider when reviewing

  • Ensure that you consider the wider context.
  • Does it work when run on your machine?
  • Is it clear what the code is doing?
  • Do the commit messages explain why the changes were made?
  • Are there all the unit tests needed?
  • Has all relevant documentation been updated?

@DavidBiddle DavidBiddle marked this pull request as ready for review March 27, 2024 09:22
@DavidBiddle DavidBiddle marked this pull request as draft March 27, 2024 09:36
@DavidBiddle DavidBiddle force-pushed the allow-archived-forms-to-be-made-live branch from f27a1f7 to aa5c219 Compare March 27, 2024 16:23
@DavidBiddle DavidBiddle marked this pull request as ready for review March 27, 2024 16:24
stephencdaly
stephencdaly reviewed Mar 27, 2024
View reviewed changes
Copy link
Contributor

@stephencdaly stephencdaly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - but has a test mistakenly been removed?

spec/state_machines/form_state_machine_spec.rb Outdated Show resolved Hide resolved
@DavidBiddle DavidBiddle force-pushed the allow-archived-forms-to-be-made-live branch from aa5c219 to 46e7a0e Compare March 27, 2024 16:54
@DavidBiddle
Allow archived forms to be made live
3db6b1f 
Updates the state machine to allow archived and archived_with_draft
forms to be made live. This will enable us to implement unarchiving a
form in forms-admin.
@DavidBiddle DavidBiddle force-pushed the allow-archived-forms-to-be-made-live branch from 46e7a0e to 3db6b1f Compare March 27, 2024 16:55
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
3 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@DavidBiddle DavidBiddle added this pull request to the merge queue Mar 27, 2024
Merged via the queue into main with commit 8ae0224 Mar 27, 2024
3 checks passed
@DavidBiddle DavidBiddle deleted the allow-archived-forms-to-be-made-live branch March 27, 2024 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephencdaly stephencdaly stephencdaly approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DavidBiddle @stephencdaly