Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ad7124 #1521

Merged
merged 3 commits into from
Dec 4, 2024
Merged

Fix ad7124 #1521

merged 3 commits into from
Dec 4, 2024

Conversation

sarpadi
Copy link
Contributor

@sarpadi sarpadi commented Nov 20, 2024 •
edited
Loading

PR Description

Required for RDY interrupt support. Updated SPI controller refclk

PR Type

  • Bug fix (change that fixes an issue)
  • New feature (change that adds new functionality)
  • Breaking change (has dependencies in other repos or will cause CI to fail)

PR Checklist

  • I have followed the code style guidelines
  • I have performed a self-review of changes
  • I have compiled all hdl projects and libraries affected by this PR
  • I have tested in hardware affected projects, at least on relevant boards
  • I have commented my code, at least hard-to-understand parts
  • I have signed off all commits from this PR
  • I have updated the documentation (wiki pages, ReadMe files, Copyright etc)
  • I have not introduced new Warnings/Critical Warnings on compilation
  • I have added new hdl testbenches or updated existing ones

@sarpadi sarpadi marked this pull request as ready for review November 29, 2024 07:07
@sarpadi
ad7124: Tie MISO to GPIO
ff03a02 
Required for interpreting the READY funtion of the MISO pin which needs irq support

Signed-off-by: sarpadi <[email protected]>
@sarpadi
ad7124: Update docs
6561523 
Signed-off-by: sarpadi <[email protected]>
@sarpadi
ad7124/de10nano: Change SYS SPI ref clock to 80MHz
afdf964 
Signed-off-by: sarpadi <[email protected]>
@sarpadi sarpadi force-pushed the fix_ad7124_miso_gpio_spi_clk branch from dd76a34 to afdf964 Compare December 2, 2024 11:19
@sarpadi sarpadi merged commit cacd986 into main Dec 4, 2024
3 of 5 checks passed
@sarpadi sarpadi deleted the fix_ad7124_miso_gpio_spi_clk branch December 4, 2024 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acostina acostina acostina approved these changes

@IuliaCMoldovan IuliaCMoldovan Awaiting requested review from IuliaCMoldovan IuliaCMoldovan is a code owner

@gastmaier gastmaier Awaiting requested review from gastmaier gastmaier is a code owner

@StancaPop StancaPop Awaiting requested review from StancaPop StancaPop is a code owner

@LBFFilho LBFFilho Awaiting requested review from LBFFilho LBFFilho is a code owner

@AndreiGrozav AndreiGrozav Awaiting requested review from AndreiGrozav AndreiGrozav is a code owner

@PopPaul2021 PopPaul2021 Awaiting requested review from PopPaul2021 PopPaul2021 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sarpadi @acostina