Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AD7192 driver new features and devicetrees #2554

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

AD7192 driver new features and devicetrees #2554

wants to merge 13 commits into from

Commits on Nov 4, 2024

  1. dt-bindings: iio: ad7192: Add mandatory reference voltage source 

    Add required reference voltage (VRef) supply regulator.

AD7192 requires three independent voltage sources: DVdd, AVdd and VRef
(on REFINx pin pairs).

Fixes: b581f74 ("staging: iio: adc: ad7192: move out of staging")
Signed-off-by: Fabrizio Lamarque <[email protected]>
Acked-by: Conor Dooley <[email protected]>
Cc: <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Jonathan Cameron <[email protected]>
    @romandariana
    Fabrizio Lamarque authored and romandariana committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    283ef0b View commit details
    Browse the repository at this point in the history

  2. iio: adc: ad7192: Use standard attribute 

    Replace custom attribute filter_low_pass_3db_frequency_available with
standard attribute.

Store the available values in ad7192_state struct.

The function that used to compute those values replaced by
ad7192_update_filter_freq_avail().

Function ad7192_show_filter_avail() is no longer needed.

Note that the initial available values are hardcoded.

Also moved the mutex lock and unlock in order to protect the whole
switch statement since each branch modifies the state of the device.

Reviewed-by: David Lechner <[email protected]>
Signed-off-by: Alisa-Dariana Roman <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Jonathan Cameron <[email protected]>
    @romandariana
    romandariana committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    0cb8bbd View commit details
    Browse the repository at this point in the history

  3. dt-bindings: iio: adc: ad7192: Add aincom supply 

    AINCOM should actually be a supply. AINx inputs are referenced to AINCOM
in pseudo-differential operation mode. AINCOM voltage represents the
offset of corresponding channels.

Reviewed-by: Rob Herring (Arm) <[email protected]>
Signed-off-by: Alisa-Dariana Roman <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Jonathan Cameron <[email protected]>
    @romandariana
    romandariana committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    f7fe997 View commit details
    Browse the repository at this point in the history

  4. iio: adc: ad7192: Add aincom supply 

    AINCOM should actually be a supply. AINx inputs are referenced to AINCOM
in pseudo-differential operation mode. AINCOM voltage represents the
offset of corresponding channels.

Signed-off-by: Alisa-Dariana Roman <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Jonathan Cameron <[email protected]>
    @romandariana
    romandariana committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    c63b252 View commit details
    Browse the repository at this point in the history

  5. dt-bindings: iio: adc: ad7192: Add AD7194 support 

    Unlike the other AD719Xs, AD7194 has configurable channels. The user can
dynamically configure them in the devicetree.

Also add an example for AD7194 devicetree.

Signed-off-by: Alisa-Dariana Roman <[email protected]>
Reviewed-by: Conor Dooley <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Jonathan Cameron <[email protected]>
    @romandariana
    romandariana committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    d3c16d7 View commit details
    Browse the repository at this point in the history

  6. iio: adc: ad7192: Add AD7194 support 

    Unlike the other AD719Xs, AD7194 has configurable channels. The user can
dynamically configure them in the devicetree.

Add sigma_delta_info member to chip_info structure. Since AD7194 is the
only chip that has no channel sequencer, num_slots should remain
undefined.

Also modify config AD7192 description for better scaling.

Signed-off-by: Alisa-Dariana Roman <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Jonathan Cameron <[email protected]>
    @romandariana
    romandariana committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    3ff64fa View commit details
    Browse the repository at this point in the history

  7. iio: adc: ad7192: Clean up dev 

    Clean up by using a local variable struct device *dev. Also use
dev_err_probe where possible.

Signed-off-by: Alisa-Dariana Roman <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Jonathan Cameron <[email protected]>
    @romandariana
    romandariana committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    4f1b0b9 View commit details
    Browse the repository at this point in the history

  8. iio: adc: ad7192: use devm_regulator_get_enable_read_voltage 

    This makes use of the new devm_regulator_get_enable_read_voltage()
function to reduce boilerplate code.

Error messages have changed slightly since there are now fewer places
where we print an error. The rest of the logic of selecting which
supply to use as the reference voltage remains the same.

Also 1000 is replaced by MILLI in a few places for consistency.

Signed-off-by: David Lechner <[email protected]>
Signed-off-by: Alisa-Dariana Roman <[email protected]>
Reviewed-by: Conor Dooley <[email protected]>
Link: https://patch.msgid.link/[email protected]
Signed-off-by: Jonathan Cameron <[email protected]>
    @dlech @romandariana
    dlech authored and romandariana committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    32b5fef View commit details
    Browse the repository at this point in the history

  9. dt-bindings: iio: adc: ad7192: Update clock config 

    There are actually 4 configuration modes of clock source for AD719X
devices. Either a crystal can be attached externally between MCLK1 and
MCLK2 pins, or an external CMOS-compatible clock can drive the MCLK2
pin. The other 2 modes make use of the 4.92MHz internal clock.

To configure external clock as either a crystal or a CMOS-compatible
clock, changing the register settings is necessary. Therefore, add clock
name xtal alongside mclk. By selecting one or the other, the register is
configured.

The presence of an external clock source is optional, not required. When
both clocks and clock-names properties are present, an external clock
source is used. If the intention is to use the internal clock, both
properties should be absent. Modify required properties accordingly.

Signed-off-by: Alisa-Dariana Roman <[email protected]>
Reviewed-by: Conor Dooley <[email protected]>
Link: https://patch.msgid.link/[email protected]
Signed-off-by: Jonathan Cameron <[email protected]>
    @romandariana
    romandariana committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    a838281 View commit details
    Browse the repository at this point in the history

  10. iio: adc: ad7192: Update clock config 

    There are actually 4 configuration modes of clock source for AD719X
devices. Either a crystal can be attached externally between MCLK1 and
MCLK2 pins, or an external CMOS-compatible clock can drive the MCLK2
pin. The other 2 modes make use of the 4.92MHz internal clock.

Undocumented properties adi,int-clock-output-enable and adi,clock-xtal
still supported for backward compatibility, but their use is highly
discouraged. Use cleaner alternative of configuring external clock by
using clock names mclk and xtal.

Functionality of AD7192_CLK_INT_CO will be implemented in complementary
patch by adding clock provider.

Signed-off-by: Alisa-Dariana Roman <[email protected]>
Reviewed-by: Nuno Sa <[email protected]>
Link: https://patch.msgid.link/[email protected]
Signed-off-by: Jonathan Cameron <[email protected]>
    @romandariana
    romandariana committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    b3fe7e1 View commit details
    Browse the repository at this point in the history

  11. dt-bindings: iio: adc: ad7192: Add clock provider 

    Internal clock of AD719X devices can be made available on MCLK2 pin. Add
clock provider to support this functionality when clock cells property
is present.

The clock source can be either provided externally or the internal clock
is used. Pair of clocks and clock-names property is mutally exclusive
with #clock-cells property.

Modify second example to showcase the mode where internal clock is used.

Signed-off-by: Alisa-Dariana Roman <[email protected]>
Acked-by: Conor Dooley <[email protected]>
Link: https://patch.msgid.link/[email protected]
Signed-off-by: Jonathan Cameron <[email protected]>
    @romandariana
    romandariana committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    a7afcdf View commit details
    Browse the repository at this point in the history

  12. iio: adc: ad7192: Add clock provider 

    Internal clock of AD719X devices can be made available on MCLK2 pin. Add
clock provider to support this functionality when clock cells property
is present.

Signed-off-by: Alisa-Dariana Roman <[email protected]>
Reviewed-by: Nuno Sa <[email protected]>
Link: https://patch.msgid.link/[email protected]
Signed-off-by: Jonathan Cameron <[email protected]>
    @romandariana
    romandariana committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    73a4ada View commit details
    Browse the repository at this point in the history

  13. arm: dts: Add AD719x dts for cora 

    Add AD7190, AD7192, AD7193, AD7194 and AD7195 devicetrees for Cora z7s
board.

Signed-off-by: Alisa-Dariana Roman <[email protected]>
    @romandariana
    romandariana committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    eb09975 View commit details
    Browse the repository at this point in the history