Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dashboard): manage dashboards by org_name #331

Merged
merged 18 commits into from
Jan 4, 2024
Merged

feat(dashboard): manage dashboards by org_name #331

merged 18 commits into from
Jan 4, 2024

Conversation

Nemental
Copy link
Collaborator

SUMMARY

Like #318, but for grafana_dashboard :)
Instead of specifying org_id, you can use org_name...

Additionally, the grafana_dashbaord tests have been refactored

ISSUE TYPE
  • Bugfix Pull Request
  • Feature Pull Request
COMPONENT NAME

module: grafana_dashboard

ADDITIONAL INFORMATION

Copy link

codecov bot commented Nov 29, 2023

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (757d7ae) 71.06% compared to head (e9b2e3b) 70.98%.

Files Patch % Lines
plugins/modules/grafana_dashboard.py 60.00% 3 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #331      +/-   ##
==========================================
- Coverage   71.06%   70.98%   -0.09%     
==========================================
  Files          18       18              
  Lines        1863     1875      +12     
  Branches      321      325       +4     
==========================================
+ Hits         1324     1331       +7     
- Misses        397      399       +2     
- Partials      142      145       +3     
Flag Coverage Δ
integration 69.69% <60.00%> (-0.12%) ⬇️
sanity 23.58% <13.33%> (-0.13%) ⬇️
units 65.59% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Nemental

This comment was marked as resolved.

@Nemental Nemental marked this pull request as draft December 1, 2023 08:40
@Nemental Nemental marked this pull request as ready for review December 1, 2023 10:30
@Nemental Nemental merged commit c4da526 into ansible-collections:main Jan 4, 2024
18 of 20 checks passed
@Nemental Nemental deleted the feat/dashboard-by-org-name branch January 4, 2024 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants