Code refactoring + Acceptance/Unit testing #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abikouo
force-pushed
the
refactor_20240417
branch
from
a3572b4
to
98da17c
Compare
gravesm
reviewed
Apr 22, 2024
There was a problem hiding this comment.
Most/nearly all of the refactoring in here seems to be to try and hide the ugliness of all the type assertions required by the SDK. If we were going to keep using the SDK it would probably be worth doing something like this. I think it's likely we'll upgrade to the framework soon, though. When we do that, this problem largely goes away, so I'm not sure it's worth it to do all this refactoring.
What I would really like to see is a PR that fixes the one bug you mentioned, and a PR that switches to using the test framework. The testing changes are sorely needed and unlikely to change much when switching to the framework.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces the following changes:
utils.go. Creates a Parser struct to parseschema.ResourceDataavoid repeating type assertion into all resource/data.tests/integrationas this was drastically performing a file and using Terraform acceptance tests framework insteadWait()function when usingexec.Commandas this is raising errors because the command is started usingCombinedOutput()