Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cli: flip no_extend to auto_extend internally #1119

Merged
merged 2 commits into from
Apr 30, 2024

Conversation

CriesofCarrots
Copy link

Problem

#791 adds some unintuitive double-negative logic to the CLI (eg !no_extend)

Summary of Changes

Change internal logic: no_extend > auto_extend

Copy link

@buffalojoec buffalojoec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hehe, "here, I'll just show you what I mean".

I like it, thank you!

@CriesofCarrots
Copy link
Author

hehe, "here, I'll just show you what I mean".

Sometimes it's easier 😅

Co-authored-by: Joe C <joecaulfield29@yahoo.com>
Copy link

@buffalojoec buffalojoec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again!

@CriesofCarrots CriesofCarrots added the automerge automerge Merge this Pull Request automatically once CI passes label Apr 30, 2024
@mergify mergify bot merged commit f255b31 into anza-xyz:master Apr 30, 2024
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge automerge Merge this Pull Request automatically once CI passes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants