Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli/tests: program_extend_program: Check for a specific error #1165

Conversation

ilya-bobyr
Copy link

Problem

There are many errors that could be generated, creating a possibility for false positives. We actually observed it in this test.

Summary of Changes

Specify the expected error.

There are many different errors that could be generated, creating a
possibility for false positives.  We actually observed it in this test.
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.1%. Comparing base (f291ca4) to head (26388c1).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##           master    #1165     +/-   ##
=========================================
- Coverage    82.1%    82.1%   -0.1%     
=========================================
  Files         886      886             
  Lines      236392   236392             
=========================================
- Hits       194274   194224     -50     
- Misses      42118    42168     +50     

Copy link

@CriesofCarrots CriesofCarrots left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, it will be great to check the specific error. Just one question

cli/tests/program.rs Show resolved Hide resolved
@ilya-bobyr ilya-bobyr merged commit 448d0ab into anza-xyz:master May 3, 2024
38 checks passed
@ilya-bobyr ilya-bobyr deleted the pr/program_extend-test-check-specific-error branch May 3, 2024 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants