Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes holding storages in AccountsHashVerifier for fastboot #120

Merged

Conversation

brooksprumo
Copy link

@brooksprumo brooksprumo commented Mar 6, 2024

Problem

Now that the recycler has been removed (#118), AccountsHashVerifier no longer needs to hold onto an Arc of the fastboot storages to prevent them from being recycled.

Summary of Changes

Remove holding storages in AccountsHashVerifier for fastboot

Fixes solana-labs#35431 and solana-labs#35376

Note, the first commit reverts #58, and the second commit removes holding the storages in AHV. Reviewing by commit may be easier.

I tested this PR using the same procedure as from #58.

@brooksprumo brooksprumo self-assigned this Mar 6, 2024
@codecov-commenter
Copy link

codecov-commenter commented Mar 6, 2024

Codecov Report

Attention: Patch coverage is 44.82759% with 16 lines in your changes are missing coverage. Please review.

Project coverage is 81.9%. Comparing base (e027a8b) to head (414e34f).
Report is 15 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff            @@
##           master     #120    +/-   ##
========================================
  Coverage    81.8%    81.9%            
========================================
  Files         838      837     -1     
  Lines      226389   226239   -150     
========================================
- Hits       185342   185301    -41     
+ Misses      41047    40938   -109     

@brooksprumo brooksprumo force-pushed the fastboot/no-fastboot-storages branch from c6f77de to 414e34f Compare March 11, 2024 19:43
@brooksprumo brooksprumo marked this pull request as ready for review March 11, 2024 20:41
Copy link

@jeffwashington jeffwashington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link

@apfitzge apfitzge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change lgtm - no risk of append-vecs being rugged by recycling simplifies things greatly!

@brooksprumo brooksprumo merged commit 88f6a7a into anza-xyz:master Mar 11, 2024
35 checks passed
@brooksprumo brooksprumo deleted the fastboot/no-fastboot-storages branch March 11, 2024 21:09
codebender828 pushed a commit to codebender828/agave that referenced this pull request Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use case: Repeated ledger-tool verify with fastboot
4 participants