Re-export curve25519-dalek from solana-zk-token-sdk #1657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 8, 2024
andreisilviudragnea
force-pushed
the
re-export-curve25519-dalek
branch
2 times, most recently
from
49bb736 to
0735715
Compare
andreisilviudragnea
force-pushed
the
re-export-curve25519-dalek
branch
from
0735715 to
054c684
Compare
samkim-crypto
approved these changes
Jun 10, 2024
|
@samkim-crypto Does this PR need backporting to |
|
Yeah SPL is currently on Solana version 1.18. We have two options here:
Generally backporting is discouraged for non-security related changes and there is also a strict review process. It seems like we can wait until v2.0 is cut, which I believe is just around the corner. @yihau wdyt? |
|
I think we can wait for 2.0. we will cut that branch soon! btw, we also can do a trick here to pass the spl downstream tests. let's fix the failed test first, I will take care of this hack |
samkim-crypto
pushed a commit
to samkim-crypto/agave
that referenced
this pull request
Jul 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The
spl-token-clientcrate from solana-program-library repository started depending directly on curve-25519-dalek v3.2.1 since solana-labs/solana-program-library#5258. This blocks #513 which tries to updatecurve-25519-dalekto a newer version.Summary of Changes
Re-exported
curve25519-dalekcrate fromsolana-zk-token-sdkcrate in order to remove specifying an explicit version (inCargo.toml) forcurve-25519-dalekinsolana-program-libraryrepository.@samkim-crypto