Bump curve25519-dalek from 3.2.1 to 4.1.2

[andreisilviudragnea]

• Bumped curve25519-dalek from 3.2.1 to 4.1.2
• Fixed sha3 version mismatch
• Fixed bump rand to 0.8.5 in build(deps): bump rand from 0.7.3 to 0.8.5 #36

Problem

Dependabot tried to bump rand to 0.8.5 in #36, but failed to do so.

Summary of Changes

I updated the necessary dependencies together for rand update to succeed:

• curve25519-dalek
• sha3
• rand

Fixes #36

[samkim-crypto]

Thanks for the contribution! Everything looks good to me overall! Let's just fix the CI issues 🙏 . Can you rebase?

[samkim-crypto]

Suggested change

	.map(|slice| {
	CompressedRistretto::from_slice(slice).expect("Input slice should have a length of 32")
	})
	.and_then(|slice| CompressedRistretto::from_slice(slice).ok())

Since we are returning None if the input is wrong length, it seems like we can just add .ok() here and remove the line above that does the length check.

[samkim-crypto]

@andreisilviudragnea, I was wondering if you still had plans to update this PR? It is completely fine if not since we have another community PR that does the same: #946. If you are still willing to work on this PR, please let me know by tomorrow 🙏 since we do need to bump the dalek crate.

[andreisilviudragnea]

I can update it in a few minutes if it's ok

[andreisilviudragnea]

@samkim-crypto There are a few problems to fix on CI, but let's handle them one by one.

First of all, all errors in CI related to error[E0635]: unknown feature stdarch_x86_avx512 are caused by the fact that the anzaxyz/ci:rust_1.76.0_nightly-2024-01-05 image is too old and does not include the feature stdarch_x86_avx512 (I got lost in Rust repository Git history. The commit which includes the stdarch_x86_avx512 feature should be 18de239e: add stdarch_x86_avx512 feature flag for AVX-512-supporting architectures 23.02.2024, 05:26 AquaEBM).

So the first step is to create a CI image with a newer Rust Nightly version than 23.02.2024.

I see @brooksprumo last updated the CI image in solana-labs#34673, so they should know how to update it to a newer Rust Nightly than 23.02.2024.

[yihau]

@andreisilviudragnea sorry for the late. we have merged the bumping PR! you can rebase and continue with this one!

[yihau]

looks like we run into some other issues 🫠 If you don't mind, I can take this one over. I will make sure to credit you and keep your name!

[andreisilviudragnea]

@yihau Hello, ok, thank you, as I am quite crowded these days.

[ItsFunny]

when will this be merged ?

[andreisilviudragnea]

@yihau I wanna try to fix this this weekend.

[andreisilviudragnea]

Hello. First of all, I don't know why the latest CI trigger did not run the Downstream project - SPL workflow. But looking at a previous run on this branch, the error:

error[E0277]: cannot multiply `&spl_token_2022::solana_zk_token_sdk::encryption::pedersen::PedersenCommitment` by `Scalar`
   --> token/client/src/proof_generation.rs:376:82
    |
376 |         fee_commitment * one_in_basis_points_scalar - transfer_amount_commitment * fee_rate_scalar;
    |                                                                                  ^ no implementation for `&spl_token_2022::solana_zk_token_sdk::encryption::pedersen::PedersenCommitment * Scalar`
    |
    = help: the trait `Mul<Scalar>` is not implemented for `&spl_token_2022::solana_zk_token_sdk::encryption::pedersen::PedersenCommitment`
    = help: the following other types implement trait `Mul<Rhs>`:
              <spl_token_2022::solana_zk_token_sdk::encryption::pedersen::PedersenCommitment as Mul<curve25519_dalek::scalar::Scalar>>
              <spl_token_2022::solana_zk_token_sdk::encryption::pedersen::PedersenCommitment as Mul<&'b curve25519_dalek::scalar::Scalar>>
              <&'a spl_token_2022::solana_zk_token_sdk::encryption::pedersen::PedersenCommitment as Mul<&'b curve25519_dalek::scalar::Scalar>>
              <&'a spl_token_2022::solana_zk_token_sdk::encryption::pedersen::PedersenCommitment as Mul<curve25519_dalek::scalar::Scalar>>

comes from the fact that both solana-zk-token-sdk (from this repo) and spl-token-client (from solana-program-library repo) crates depend on curve25519-dalek v3.2.1 and both need to be updated at the same time.

solana-program-library repo started depending on curve25519-dalek v3.2.1 since solana-labs/solana-program-library#5258.

I suggest re-exporting curve25519-dalek from solana-zk-token-sdk crate, in order to fix the CI and remove the dependency of solana-program-library on a specific curve25519-dalek version. I created a PR for this: #1657.

After merging #1657, I will create a PR in solana-program-library repository to use the new re-exported module and remove the curve25519-dalek version from Cargo.toml file and re-try running the CI on this PR again.

@samkim-crypto

[yihau]

we also need to fix this one: https://buildkite.com/anza/agave/builds/5647

[yihau]

@andreisilviudragnea sorry, I think I will try to split/clean this commit bd41d6a into smaller pieces. it do too many things together.

btw, I will commit them to here. I want your name can be kept in the git history!

---

updated: I think I will keep you code but overwrite with mine.

[yihau]

moved to #1693

[andreisilviudragnea]

Superseded by #1693.