v1.18: deprecate get_client and get_multi_client (backport of #177)
#182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
deprecate get_client and get_multi_client (cherry picked from commit 00c984f)
gossip/src/gossip_service.rs
Outdated
| @@ -193,6 +193,7 @@ pub fn discover( | |||
| } | |||
|
|
|||
| /// Creates a ThinClient by selecting a valid node at random | |||
| #[deprecated(since = "1.18.0", note = "Interface will change")] | |||
There was a problem hiding this comment.
Oh shoot, I didn't look carefully enough at this, sorry. Can you please fix this on master too?
Suggested change
| #[deprecated(since = "1.18.0", note = "Interface will change")] | |
| #[deprecated(since = "1.18.6", note = "Interface will change")] |
gossip/src/gossip_service.rs
Outdated
| @@ -208,6 +209,7 @@ pub fn get_client( | |||
| ThinClient::new(rpc, tpu, connection_cache) | |||
| } | |||
|
|
|||
| #[deprecated(since = "1.18.0", note = "Will be removed in favor of get_client")] | |||
There was a problem hiding this comment.
Suggested change
| #[deprecated(since = "1.18.0", note = "Will be removed in favor of get_client")] | |
| #[deprecated(since = "1.18.6", note = "Will be removed in favor of get_client")] |
gregcusack
requested review from
CriesofCarrots and
KirillLykov
and removed request for
KirillLykov and
CriesofCarrots
CriesofCarrots
approved these changes
Mar 11, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## v1.18 #182 +/- ##
=======================================
Coverage 81.6% 81.6%
=======================================
Files 827 827
Lines 224375 224375
=======================================
+ Hits 183114 183141 +27
+ Misses 41261 41234 -27 |
|
github says "Some checks were not successful" but CI here: https://buildkite.com/anza/agave/builds/453 is green says all checks passed. |
anwayde
pushed a commit
to firedancer-io/agave
that referenced
this pull request
Jul 23, 2024
…a-xyz#177) (anza-xyz#182) * deprecate `get_client` and `get_multi_client` (anza-xyz#177) deprecate get_client and get_multi_client (cherry picked from commit 00c984f) * bump deprecated version numbers --------- Co-authored-by: Greg Cusack <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automatic backport of pull request #177 done by Mergify.
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refreshwill re-evaluate the rules@Mergifyio rebasewill rebase this PR on its base branch@Mergifyio updatewill merge the base branch into this PR@Mergifyio backport <destination>will backport this PR on<destination>branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.com